Re: [dpdk-dev] [PATCH] net/avf: fix missing offload capabilities

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Thursday, August 2, 2018 9:56 AM
> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/avf: fix missing offload capabilities
> 
> Hi Xiaoyun,
> 
> 
> > -----Original Message-----
> > From: Li, Xiaoyun
> > Sent: Wednesday, August 1, 2018 9:35 AM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: RE: [PATCH] net/avf: fix missing offload capabilities
> >
> > Hi
> >
> > > -----Original Message-----
> > > From: Lu, Wenzhuo
> > > Sent: Wednesday, August 1, 2018 09:19
> > > To: Li, Xiaoyun <xiaoyun.li@intel.com>; Wu, Jingjing
> > > <jingjing.wu@intel.com>
> > > Cc: dev@dpdk.org; stable@dpdk.org
> > > Subject: RE: [PATCH] net/avf: fix missing offload capabilities
> > >
> > > Hi Xiaoyun,
> > >
> > >
> > > > -----Original Message-----
> > > > From: Li, Xiaoyun
> > > > Sent: Wednesday, July 25, 2018 3:15 PM
> > > > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> > > > <jingjing.wu@intel.com>
> > > > Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>;
> > > > stable@dpdk.org
> > > > Subject: [PATCH] net/avf: fix missing offload capabilities
> > > >
> > > > There are several tx/rx offload capabilities missing in AVF.
> > > > Add them in this patch since AVF supports them.
> > > >
> > > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> > > > ---
> > > >  drivers/net/avf/avf_ethdev.c | 18 ++++++++++++++++--
> > > >  1 file changed, 16 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/net/avf/avf_ethdev.c
> > > > b/drivers/net/avf/avf_ethdev.c index 0e21f8c..3a2baaf 100644
> > > > --- a/drivers/net/avf/avf_ethdev.c
> > > > +++ b/drivers/net/avf/avf_ethdev.c
> > > > @@ -518,16 +518,30 @@ avf_dev_info_get(struct rte_eth_dev *dev,
> > > > struct rte_eth_dev_info *dev_info)
> > > >  	dev_info->max_mac_addrs = AVF_NUM_MACADDR_MAX;
> > > >  	dev_info->rx_offload_capa =
> > > >  		DEV_RX_OFFLOAD_VLAN_STRIP |
> > > > +		DEV_RX_OFFLOAD_QINQ_STRIP |
> > > >  		DEV_RX_OFFLOAD_IPV4_CKSUM |
> > > >  		DEV_RX_OFFLOAD_UDP_CKSUM |
> > > > -		DEV_RX_OFFLOAD_TCP_CKSUM;
> > > > +		DEV_RX_OFFLOAD_TCP_CKSUM |
> > > > +		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
> > > > +		DEV_RX_OFFLOAD_CRC_STRIP |
> > > > +		DEV_RX_OFFLOAD_KEEP_CRC |
> > > Don't find  this flag. Does this path depend on another?
> > > Do we need to announce this capa?
> >
> > You mean KEEP_CRC? I copy the flags from i40evf.
> > In release note:
> > In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be removed,
> > default
> >   behavior without any flag will be changed to CRC strip.
> >   To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required.
> >   ``KEEP_CRC``: Keep CRC in packet
> >   No flag: Strip CRC from packet
> O, got the history.
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied to dpdk-next-net-intel.

Thanks!
Qi