From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 4EBE51B3A5; Thu, 2 Aug 2018 04:27:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2018 19:27:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,434,1526367600"; d="scan'208";a="78000777" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 01 Aug 2018 19:27:38 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 19:27:38 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 19:27:38 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.173]) with mapi id 14.03.0319.002; Thu, 2 Aug 2018 10:27:36 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "stable@dpdk.org" , "Zhao1, Wei" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe Thread-Index: AQHUIvpIatisSl8YdEWQgrqjC0ZdhaSrypnQ Date: Thu, 2 Aug 2018 02:27:36 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153262AEF@SHSMSX103.ccr.corp.intel.com> References: <1532399811-52078-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1532399811-52078-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2EyZDExZjMtYmIxMS00NjhiLWJlNzAtNTIxNzJlMTc2YjM2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSWNBZGQxbW9aZWRwazVUOTMxb29rdUpGdVQ1dENXZ2c5akNyU3R0VVFHekFueDNybTJlUmp4NXZNd0dZWHhwTiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 02:27:45 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao > Sent: Tuesday, July 24, 2018 10:37 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; stable@dpdk.org; Zhao1, Wei > ; Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config > from ixgbe >=20 > There is CRC related ifdefs for ixgbe: > CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=3Dn > It is used in VF drivers ixgbevf_dev_configure() functions. > VF cannot change the CRC strip behavior and based on what PF configured i= t > needs to response proper to user > ixgbevf_dev_configure() request. Right now what PF set is defined by abov= e > config options but this method is too static. >=20 > Signed-off-by: Wei Zhao > Signed-off-by: Wenzhuo Lu > --- > app/test-pmd/parameters.c | 6 ++++++ > app/test-pmd/testpmd.c | 2 ++ > app/test-pmd/testpmd.h | 1 + > drivers/net/ixgbe/ixgbe_ethdev.c | 20 ++++++++++---------- > lib/librte_ethdev/rte_ethdev.h | 1 + > 5 files changed, 20 insertions(+), 10 deletions(-) Its better separate the patch for ethdev, ixgbe, and testpmd.