DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/i40e: remove invalid comment
@ 2018-09-13 11:21 Ferruh Yigit
  2018-09-13 12:48 ` Zhang, Qi Z
  0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2018-09-13 11:21 UTC (permalink / raw)
  To: Beilei Xing, Qi Zhang; +Cc: dev, Ferruh Yigit

Comments says "no csum error report support" but there is no check
related csum offloads. Removing the comment.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

---
Patch can be other way around too, adding the csum check mentioned in
the comment.
Please comment if this is the correct thing to do.
---
 drivers/net/i40e/i40e_rxtx_vec_common.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h
index 63cb17742..f00f6d648 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
@@ -199,9 +199,7 @@ i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)
 	if (fconf->mode != RTE_FDIR_MODE_NONE)
 		return -1;
 
-	 /* - no csum error report support
-	 * - no header split support
-	 */
+	 /* no header split support */
 	if (rxmode->offloads & DEV_RX_OFFLOAD_HEADER_SPLIT)
 		return -1;
 
-- 
2.17.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/i40e: remove invalid comment
  2018-09-13 11:21 [dpdk-dev] [PATCH] net/i40e: remove invalid comment Ferruh Yigit
@ 2018-09-13 12:48 ` Zhang, Qi Z
  0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2018-09-13 12:48 UTC (permalink / raw)
  To: Yigit, Ferruh, Xing, Beilei; +Cc: dev



> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, September 13, 2018 7:21 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH] net/i40e: remove invalid comment
> 
> Comments says "no csum error report support" but there is no check related
> csum offloads. Removing the comment.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-13 12:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-13 11:21 [dpdk-dev] [PATCH] net/i40e: remove invalid comment Ferruh Yigit
2018-09-13 12:48 ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).