From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 4E1144D3A for ; Fri, 21 Sep 2018 17:48:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2018 08:48:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,285,1534834800"; d="scan'208";a="88196710" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 21 Sep 2018 08:48:40 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 21 Sep 2018 08:48:40 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 21 Sep 2018 08:48:39 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.245]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.220]) with mapi id 14.03.0319.002; Fri, 21 Sep 2018 23:48:37 +0800 From: "Zhang, Qi Z" To: faicker.mo , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front to jump over ntuple filter case Thread-Index: AQHUTxO2fn/UEcpTCkeRwIOwrNfWWaT65fyg Date: Fri, 21 Sep 2018 15:48:37 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532A1A27@SHSMSX103.ccr.corp.intel.com> References: <1537249732-7530-1-git-send-email-faicker.mo@ucloud.cn> In-Reply-To: <1537249732-7530-1-git-send-email-faicker.mo@ucloud.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTM4NzEzNTgtZWUzMS00NDM2LWFkOGMtMzNjNDkxMGI1NmM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicElzVndmdXRuRDVYYUtwQVpxb1RaTHVVYnkxUmdET3lmb0Fub2tGS0VIdDM5cmxPdW1rbzJHYW1xUWNPOUMyYiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front to jump over ntuple filter case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 15:48:41 -0000 Hi Faicker: > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of faicker.mo > Sent: Tuesday, September 18, 2018 1:49 PM > To: dev@dpdk.org > Cc: faicker.mo > Subject: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front to jump = over > ntuple filter case >=20 > From: "faicker.mo" >=20 > Check in func ntuple_filter_to_5tuple is too late for fdir filter rule, a= dd check > in func cons_parse_ntuple_filter. Would you explain more about the intention for this patch? Though it can be more fast to reject an invalid flow, but why it is too lat= e in your case?=20 Thanks Qi >=20 > Signed-off-by: faicker.mo > --- > drivers/net/ixgbe/ixgbe_flow.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flo= w.c > index 1adf1b8..f0fafeb 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -363,6 +363,17 @@ const struct rte_flow_action *next_no_void_action( > item, "Not supported by ntuple filter"); > return -rte_errno; > } > + if ((ipv4_mask->hdr.src_addr !=3D 0 && > + ipv4_mask->hdr.src_addr !=3D UINT32_MAX) || > + (ipv4_mask->hdr.dst_addr !=3D 0 && > + ipv4_mask->hdr.dst_addr !=3D UINT32_MAX) || > + (ipv4_mask->hdr.next_proto_id !=3D UINT8_MAX && > + ipv4_mask->hdr.next_proto_id !=3D 0)) { > + rte_flow_error_set(error, > + EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, > + item, "Not supported by ntuple filter"); > + return -rte_errno; > + } >=20 > filter->dst_ip_mask =3D ipv4_mask->hdr.dst_addr; > filter->src_ip_mask =3D ipv4_mask->hdr.src_addr; @@ -432,6 +443,15 > @@ const struct rte_flow_action *next_no_void_action( > item, "Not supported by ntuple filter"); > return -rte_errno; > } > + if ((tcp_mask->hdr.src_port !=3D 0 && > + tcp_mask->hdr.src_port !=3D UINT16_MAX) || > + (tcp_mask->hdr.dst_port !=3D 0 && > + tcp_mask->hdr.dst_port !=3D UINT16_MAX)) { > + rte_flow_error_set(error, > + EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, > + item, "Not supported by ntuple filter"); > + return -rte_errno; > + } >=20 > filter->dst_port_mask =3D tcp_mask->hdr.dst_port; > filter->src_port_mask =3D tcp_mask->hdr.src_port; @@ -467,6 > +487,15 @@ const struct rte_flow_action *next_no_void_action( > item, "Not supported by ntuple filter"); > return -rte_errno; > } > + if ((udp_mask->hdr.src_port !=3D 0 && > + udp_mask->hdr.src_port !=3D UINT16_MAX) || > + (udp_mask->hdr.dst_port !=3D 0 && > + udp_mask->hdr.dst_port !=3D UINT16_MAX)) { > + rte_flow_error_set(error, > + EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, > + item, "Not supported by ntuple filter"); > + return -rte_errno; > + } >=20 > filter->dst_port_mask =3D udp_mask->hdr.dst_port; > filter->src_port_mask =3D udp_mask->hdr.src_port; > -- > 1.8.3.1 >=20