From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 44EA41B184 for ; Wed, 26 Sep 2018 13:27:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 04:27:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,306,1534834800"; d="scan'208";a="93392771" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 26 Sep 2018 04:26:40 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 26 Sep 2018 04:26:40 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 26 Sep 2018 04:26:39 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.245]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.220]) with mapi id 14.03.0319.002; Wed, 26 Sep 2018 19:26:38 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: remove keeping CRC configuration for VF Thread-Index: AQHUVTxaI96J6f4YEkaFs7YMoYOFZ6UCbHHg Date: Wed, 26 Sep 2018 11:26:37 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532A6879@SHSMSX103.ccr.corp.intel.com> References: <1537926663-21153-1-git-send-email-beilei.xing@intel.com> In-Reply-To: <1537926663-21153-1-git-send-email-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjk4MDFhNDQtZjZjMS00NjRiLWE3ZDctYTBmOWZiZTViNTExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidk1QaTlzbkl1cUk0QjNEbVJ0eVkrV0dNODY5Yk5PT0xwTEFQWURGdWJGNEFXYUxqRVhZZWFrVThzcitrRm4rYiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove keeping CRC configuration for VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 11:27:29 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, September 26, 2018 9:51 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH] net/i40e: remove keeping CRC configuration for VF >=20 > Remove keeping CRC configuration since it's not supported by i40e VF. >=20 > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_ethdev_vf.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index f9cedf5..4fa9d8d 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1523,7 +1523,6 @@ i40evf_dev_configure(struct rte_eth_dev *dev) > struct i40e_adapter *ad =3D > I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > struct rte_eth_conf *conf =3D &dev->data->dev_conf; > - struct i40e_vf *vf; >=20 > /* Initialize to TRUE. If any of Rx queues doesn't meet the bulk > * allocation or vector Rx preconditions we will reset it. > @@ -1533,17 +1532,9 @@ i40evf_dev_configure(struct rte_eth_dev *dev) > ad->tx_simple_allowed =3D true; > ad->tx_vec_allowed =3D true; >=20 > - /* For non-DPDK PF drivers, VF has no ability to disable HW > - * CRC strip, and is implicitly enabled by the PF. > - */ > if (conf->rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC) { > - vf =3D I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > - if ((vf->version_major =3D=3D VIRTCHNL_VERSION_MAJOR) && > - (vf->version_minor <=3D VIRTCHNL_VERSION_MINOR)) { > - /* Peer is running non-DPDK PF driver. */ > - PMD_INIT_LOG(ERR, "VF can't disable HW CRC Strip"); > - return -EINVAL; > - } > + PMD_INIT_LOG(ERR, "VF can't disable HW CRC Strip"); > + return -EINVAL; > } Should we remove the whole branch here? the offload configure check is alre= ady covered at rte_eth_dev_configure. >=20 > return i40evf_init_vlan(dev); > @@ -2180,7 +2171,6 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > DEV_RX_OFFLOAD_UDP_CKSUM | > DEV_RX_OFFLOAD_TCP_CKSUM | > DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > - DEV_RX_OFFLOAD_KEEP_CRC | > DEV_RX_OFFLOAD_SCATTER | > DEV_RX_OFFLOAD_JUMBO_FRAME | > DEV_RX_OFFLOAD_VLAN_FILTER; > -- > 2.5.5