From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id EE3B81B13C; Tue, 23 Oct 2018 22:32:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2018 13:32:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,417,1534834800"; d="scan'208";a="273854797" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 23 Oct 2018 13:32:21 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 23 Oct 2018 13:32:21 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 23 Oct 2018 13:32:20 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.102]) with mapi id 14.03.0415.000; Wed, 24 Oct 2018 04:32:17 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Ye, Xiaolong" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: cancel alarm handler at the end of device closure Thread-Index: AQHUamr2mg6tSATQ30K+k8mELUS4wKUr48WAgAFmRmA= Date: Tue, 23 Oct 2018 20:32:17 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532DA677@SHSMSX103.ccr.corp.intel.com> References: <20181023005428.44547-1-xiaolong.ye@intel.com> <94479800C636CB44BD422CB454846E013CCF7AA4@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013CCF7AA4@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTJhMjBmYWMtMGMxZi00MzMwLTk0ZGEtMDU2YzM4YWQ2OTFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRjNGZkoySTFOTjIwWGMyYUxyZU15cFdIY3JLVWQ1TTFMWU5FWHFqYThrMXpwSEIwdXJoSG5GUTZUcnQ1M0puYyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: cancel alarm handler at the end of device closure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 20:32:23 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Tuesday, October 23, 2018 2:10 AM > To: Ye, Xiaolong ; Zhang, Qi Z > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/i40e: cancel alarm handler at the end of device > closure >=20 >=20 >=20 > > -----Original Message----- > > From: Ye, Xiaolong > > Sent: Tuesday, October 23, 2018 8:54 AM > > To: Zhang, Qi Z ; Xing, Beilei > > > > Cc: dev@dpdk.org; Ye, Xiaolong ; > > stable@dpdk.org > > Subject: [PATCH] net/i40e: cancel alarm handler at the end of device > > closure > > > > Some operations in i40evf_dev_close like > > i40evf_dev_promiscuous_disable still need alarm handler to clear the > > pending cmd, if alarm handler is canceled in early stage of > > i40evf_dev_close, i40evf_dev_promiscuous_disable will result in failure= . > > > > Fixes: 864a800d706d ("net/i40e: remove VF interrupt handler") > > > > Cc: stable@dpdk.org > > Signed-off-by: Xiaolong Ye > > --- > > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > > b/drivers/net/i40e/i40e_ethdev_vf.c > > index baa6cc58f..52ae578d6 100644 > > --- a/drivers/net/i40e/i40e_ethdev_vf.c > > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > > @@ -2249,7 +2249,6 @@ i40evf_dev_close(struct rte_eth_dev *dev) { > > struct i40e_hw *hw =3D I40E_DEV_PRIVATE_TO_HW(dev->data- > > >dev_private); > > > > - rte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev); > > i40evf_dev_stop(dev); > > i40e_dev_free_queues(dev); > > /* > > @@ -2263,6 +2262,7 @@ i40evf_dev_close(struct rte_eth_dev *dev) > > i40evf_reset_vf(hw); > > i40e_shutdown_adminq(hw); > > i40evf_disable_irq0(hw); > > + rte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev); > > } > > > > /* > > -- > > 2.17.1 >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi