From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5582325B3; Fri, 26 Oct 2018 17:49:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2018 08:49:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,428,1534834800"; d="scan'208";a="244627062" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 26 Oct 2018 08:49:34 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Oct 2018 08:49:33 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Oct 2018 08:49:33 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.102]) with mapi id 14.03.0415.000; Fri, 26 Oct 2018 23:49:31 +0800 From: "Zhang, Qi Z" To: "Richardson, Bruce" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix Rx instability with vector mode Thread-Index: AQHUbPWr8zsLLC1UvU+LZagc1QKsFqUw2UuAgADRo4A= Date: Fri, 26 Oct 2018 15:49:31 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532DBD8B@SHSMSX103.ccr.corp.intel.com> References: <1540453252-128654-1-git-send-email-beilei.xing@intel.com> <1540535607-115720-1-git-send-email-beilei.xing@intel.com> <20181026111136.GD14620@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20181026111136.GD14620@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTMxZjdlMWQtMWVhZi00ZDE2LTg5NDQtYWVlOGUxYTk5ZWFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9sVUNOV2tPcytqYUJHNFwvZmF4VmY4aENHSmtjNHE4aHZTUThKVnZndGdBbjF3UDdKWUhzcVpCN3VuaU03a0VxIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix Rx instability with vector mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 15:49:36 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, October 26, 2018 6:12 AM > To: Xing, Beilei > Cc: Zhang, Qi Z ; dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix Rx instability with vect= or > mode >=20 > On Fri, Oct 26, 2018 at 02:33:27PM +0800, Beilei Xing wrote: > > Previously, there is instability during vector Rx if descriptor number > > is not power of 2, e.g. process hang and some Rx packets are > > unexpectedly empty. That's because vector Rx mode assumes Rx > > descriptor number is power of 2 when doing bit mask. > > This patch allows vector mode only when the number of Rx descriptor is > > power of 2. > > > > Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage") > > Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup") > > Cc: stable@dpdk.org > > > > Signed-off-by: Beilei Xing > > --- > > > Do we not limit our descriptor ring sizes to powers of two anyway?=20 Is there a > real need for non-power-of-2 ring sizes? This is tracked by some Bugzilla, seems someone is using this kind of confi= gure,=20 and I guess a more flexible queue size configure may help on the platform t= hat have limited cache?