DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/ixgbe: enable detach from secondary
@ 2018-10-25  2:48 Qi Zhang
  2018-10-27  2:50 ` Zhang, Qi Z
  0 siblings, 1 reply; 2+ messages in thread
From: Qi Zhang @ 2018-10-25  2:48 UTC (permalink / raw)
  To: wenzhuo.lu; +Cc: xueqin.lin, dev, Qi Zhang

Since we have enabled the hotplug mechanism for multi-process, it's not
necessary to return -EPERM when try detaches a device from a secondary
process.

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index c458bffc0..4c639b40c 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1303,7 +1303,7 @@ eth_ixgbe_dev_uninit(struct rte_eth_dev *eth_dev)
 	PMD_INIT_FUNC_TRACE();
 
 	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
-		return -EPERM;
+		return 0;
 
 	hw = IXGBE_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
 
@@ -1708,7 +1708,7 @@ eth_ixgbevf_dev_uninit(struct rte_eth_dev *eth_dev)
 	PMD_INIT_FUNC_TRACE();
 
 	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
-		return -EPERM;
+		return 0;
 
 	hw = IXGBE_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
 
-- 
2.13.6

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/ixgbe: enable detach from secondary
  2018-10-25  2:48 [dpdk-dev] [PATCH] net/ixgbe: enable detach from secondary Qi Zhang
@ 2018-10-27  2:50 ` Zhang, Qi Z
  0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2018-10-27  2:50 UTC (permalink / raw)
  To: Lu, Wenzhuo; +Cc: Lin, Xueqin, dev



> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, October 24, 2018 9:49 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: Lin, Xueqin <xueqin.lin@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: [PATCH] net/ixgbe: enable detach from secondary
> 
> Since we have enabled the hotplug mechanism for multi-process, it's not
> necessary to return -EPERM when try detaches a device from a secondary
> process.
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-27  2:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-25  2:48 [dpdk-dev] [PATCH] net/ixgbe: enable detach from secondary Qi Zhang
2018-10-27  2:50 ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).