From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D217625B3 for ; Sat, 27 Oct 2018 05:04:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2018 20:04:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,430,1534834800"; d="scan'208";a="103075895" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 26 Oct 2018 20:04:24 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Oct 2018 20:04:24 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Oct 2018 20:04:24 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.199]) with mapi id 14.03.0415.000; Sat, 27 Oct 2018 11:04:21 +0800 From: "Zhang, Qi Z" To: "Ye, Xiaolong" , "Xing, Beilei" CC: "dev@dpdk.org" , "Kulasek, TomaszX" Thread-Topic: [PATCH 2/2] net/i40e: correct offload not supported mask Thread-Index: AQHUbPXabjYVjeYWq02icOFHvpX9QqUyaWow Date: Sat, 27 Oct 2018 03:04:21 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532DC10B@SHSMSX103.ccr.corp.intel.com> References: <20181026063314.100992-1-xiaolong.ye@intel.com> In-Reply-To: <20181026063314.100992-1-xiaolong.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWI1MDA4YTYtODhjYi00YTllLTk3NDYtN2QxNmUzY2MwYmFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidWFcL2J4OFNIR1g0VitpUTNZVko3VVVRVlBiUXJUUnpPcERDaEtQbjl0ZWxFdFdEM05PUXlUeTB2cVZ3ZFF6V0oifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] net/i40e: correct offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2018 03:04:26 -0000 > -----Original Message----- > From: Ye, Xiaolong > Sent: Friday, October 26, 2018 1:33 AM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Ye, Xiaolong ; Kulasek, TomaszX > > Subject: [PATCH 2/2] net/i40e: correct offload not supported mask >=20 > Just as the name I40E_TX_OFFLOAD_NOTSUP_MASK indicates, it should be > the mask of unsupported features (either not in PKT_TX_OFFLOAD_MASK or > in I40E_TX_OFFLOAD_MASK), however, xor will not get desired result here, > assume bit 0 of PKT_TX_OFFLOAD_MASK and I40E_TX_OFFLOAD_MAKS are > 0 which means corresponding feature is not supported in both sides, then = we > get value of bit 0 of I40E_TX_OFFLOAD_NOTSUP_MASK which is 0 via xor, it > implies that it is supported which doesn't meet our expectation. >=20 > Correct it by a NOT-AND operation. >=20 > Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation") >=20 > Cc: tomaszx.kulasek@intel.com > Signed-off-by: Xiaolong Ye Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi