From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_mp_request_sync() memleak on device hotplug
Date: Mon, 29 Oct 2018 14:25:55 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532DCAC6@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <FBE7E039FA50BF47A673AD0BD3CD56A846225467@HASMSX105.ger.corp.intel.com>
> -----Original Message-----
> From: Stojaczyk, Dariusz
> Sent: Monday, October 29, 2018 7:02 AM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] eal: fix rte_mp_request_sync() memleak on
> device hotplug
>
> > -----Original Message-----
> > From: Burakov, Anatoly
> > Sent: Friday, October 26, 2018 4:22 PM
> > To: Stojaczyk, Dariusz <dariusz.stojaczyk@intel.com>; dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_mp_request_sync() memleak
> > on device hotplug
> >
> > <SNIP>
> >
> > This is correct but incomplete. There are also numerous error
> > conditions which check for number of received responses to be a
> > particular number, and if the number don't match, we just exit without
> freeing memory.
> > Those errors need to free the memory as well.
> >
>
> Yup, thanks. I pushed v2 with one extra free() in the function notifying
> secondary processes.
> The function which notifies the primary process has a similar error check -
> - `if (mp_reply.nb_received == 1)` - but I figured if there's more than 1
> primary process replying, then the memory leak is your smallest problem.
Good capture!
Thanks for fix this.
>
> > --
> > Thanks,
> > Anatoly
next prev parent reply other threads:[~2018-10-29 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 10:46 Darek Stojaczyk
2018-10-26 14:22 ` Burakov, Anatoly
2018-10-29 12:02 ` Stojaczyk, Dariusz
2018-10-29 14:25 ` Zhang, Qi Z [this message]
2018-10-29 11:47 ` [dpdk-dev] [PATCH v2] eal: fix IPC " Darek Stojaczyk
2018-10-30 10:15 ` Burakov, Anatoly
2018-10-31 17:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532DCAC6@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).