From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"geoffrey.lv@gmail.com" <geoffrey.lv@gmail.com>,
"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: fix unexpected resource mapping override
Date: Tue, 30 Oct 2018 15:19:54 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532DD668@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <4370007.3MeJCCFLt4@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Sunday, October 28, 2018 6:27 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>; geoffrey.lv@gmail.com;
> ajit.khaparde@broadcom.com; stable@dpdk.org; gaetan.rivet@6wind.com;
> arybchenko@solarflare.com
> Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: fix unexpected resource mapping
> override
>
> 27/10/2018 05:20, Qi Zhang:
> > When scanning an already plugged device, the virtual address of mapped
> > PCI resource in rte_pci_device will be overridden with 0, that may
> > cause driver does not work correctly.
> > The fix is not to update any rte_pci_device's field if the being
> > scanned device's driver is already probed.
> >
> > Bugzilla ID: 85
> > Fixes: c752998b5e2e ("pci: introduce library and driver")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Lv Geoffrey <geoffrey.lv@gmail.com>
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>
> I still think something must be fixed in PCI scan.
We are fixing something in PCI scan, right?
>
> Anyway, there is an error:
> passing argument 1 of ‘rte_dev_is_probed’ from incompatible pointer type
So sorry, I should compile it first
.
>
>
next prev parent reply other threads:[~2018-10-30 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 3:20 Qi Zhang
2018-10-28 23:26 ` Thomas Monjalon
2018-10-30 15:19 ` Zhang, Qi Z [this message]
2018-10-31 18:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532DD668@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=geoffrey.lv@gmail.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).