Re: [dpdk-dev] [PATCH] eal: fix memleak on device hotplug rollback

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Stojaczyk, Dariusz
> Sent: Wednesday, October 31, 2018 8:17 AM
> To: dev@dpdk.org
> Cc: Stojaczyk, Dariusz <dariusz.stojaczyk@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: [PATCH] eal: fix memleak on device hotplug rollback
> 
> Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> Cc: qi.z.zhang@intel.com
> Cc: anatoly.burakov@intel.com
> 
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Thanks
Qi

> ---
>  lib/librte_eal/common/hotplug_mp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/common/hotplug_mp.c
> b/lib/librte_eal/common/hotplug_mp.c
> index b68e4cabb..7c9fcc46c 100644
> --- a/lib/librte_eal/common/hotplug_mp.c
> +++ b/lib/librte_eal/common/hotplug_mp.c
> @@ -243,7 +243,7 @@ static void __handle_primary_request(void *param)
>  		da = calloc(1, sizeof(*da));
>  		if (da == NULL) {
>  			ret = -ENOMEM;
> -			goto quit;
> +			break;
>  		}
> 
>  		ret = rte_devargs_parse(da, req->devargs); @@ -266,6 +266,8 @@
> static void __handle_primary_request(void *param)
> 
>  		ret = local_dev_remove(dev);
>  quit:
> +		free(da->args);
> +		free(da);
>  		break;
>  	default:
>  		ret = -EINVAL;
> --
> 2.17.1