From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Ilya Maximets <i.maximets@samsung.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Laurent Hardy <laurent.hardy@6wind.com>,
"Wei Dai" <wei.dai@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix busy polling while fiber link update
Date: Fri, 2 Nov 2018 13:49:42 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532DEAFE@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181101160459.23586-1-i.maximets@samsung.com>
> -----Original Message-----
> From: Ilya Maximets [mailto:i.maximets@samsung.com]
> Sent: Thursday, November 1, 2018 11:05 AM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Laurent Hardy
> <laurent.hardy@6wind.com>; Wei Dai <wei.dai@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Ilya Maximets <i.maximets@samsung.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/ixgbe: fix busy polling while fiber link update
>
> If the multispeed fiber link is in DOWN state, ixgbe_setup_link could take
> around a second of busy polling. This is highly inconvenient for the case
> where single thread periodically checks the link statuses. For example, OVS
> main thread periodically updates the link statuses and hangs for a really long
> time busy waiting on ixgbe_setup_link() for a DOWN fiber ports. For case
> with 3 down ports it hangs for a 3 seconds and unable to do anything
> including packet processing.
> Fix that by shifting that workaround to a separate thread by alarm handler
> that will try to set up link if it is DOWN.
>
> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated")
> CC: stable@dpdk.org
>
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
next prev parent reply other threads:[~2018-11-02 13:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180831123824eucas1p1cd2981c716c4764703e24c3eeb4d33c7@eucas1p1.samsung.com>
2018-08-31 12:39 ` [dpdk-dev] [PATCH] " Ilya Maximets
2018-09-04 6:08 ` Zhang, Qi Z
2018-09-10 15:08 ` Ilya Maximets
2018-09-12 6:49 ` Zhang, Qi Z
2018-09-12 8:05 ` Ilya Maximets
2018-09-12 8:28 ` Zhang, Qi Z
2018-09-21 14:25 ` Zhang, Qi Z
2018-10-03 7:43 ` Ilya Maximets
2018-10-09 10:22 ` Zhao1, Wei
2018-10-11 9:56 ` Zhao1, Wei
2018-10-11 10:26 ` Ilya Maximets
2018-10-11 12:21 ` Laurent Hardy
2018-10-12 7:36 ` Zhao1, Wei
2018-10-15 10:43 ` Laurent Hardy
2018-10-16 8:29 ` Zhao1, Wei
2018-10-12 9:19 ` Zhao1, Wei
2018-10-12 10:14 ` Ilya Maximets
2018-10-15 3:03 ` Zhao1, Wei
2018-10-15 8:40 ` Ilya Maximets
2018-10-16 8:59 ` Zhao1, Wei
2018-10-30 10:20 ` Ilya Maximets
2018-11-01 15:45 ` Zhang, Qi Z
2018-11-01 16:05 ` Ilya Maximets
[not found] ` <CGME20181101160505eucas1p1fcf268f3febaa80dcbb3e573b2fc2c68@eucas1p1.samsung.com>
2018-11-01 16:04 ` [dpdk-dev] [PATCH v2] " Ilya Maximets
2018-11-02 13:49 ` Zhang, Qi Z [this message]
2018-11-07 15:52 ` Burakov, Anatoly
2018-11-08 10:27 ` Ilya Maximets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532DEAFE@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=i.maximets@samsung.com \
--cc=konstantin.ananyev@intel.com \
--cc=laurent.hardy@6wind.com \
--cc=stable@dpdk.org \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).