From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1250D4CE4; Mon, 5 Nov 2018 18:41:11 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2018 09:41:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,468,1534834800"; d="scan'208";a="106080952" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 05 Nov 2018 09:41:10 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 5 Nov 2018 09:41:09 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 5 Nov 2018 09:41:09 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.102]) with mapi id 14.03.0415.000; Tue, 6 Nov 2018 01:41:08 +0800 From: "Zhang, Qi Z" To: Luca Boccassi , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "3chas3@gmail.com" <3chas3@gmail.com>, "stable@dpdk.org" Thread-Topic: [PATCH v3 1/2] net/ixgbe: fix x550 code to handle unidentified PHY Thread-Index: AQHUcr9gyqD1dkvYLEm0RKrmv7v0V6VBduAw Date: Mon, 5 Nov 2018 17:41:07 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532DF9A9@SHSMSX103.ccr.corp.intel.com> References: <20180815170932.23536-1-bluca@debian.org> <20181102151848.18024-1-bluca@debian.org> In-Reply-To: <20181102151848.18024-1-bluca@debian.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmY3ZGY0YWItYWI3ZS00NWE5LTgwZWEtMTgzYzUzM2ZmZWY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRUVmSHdTV0lSMzZHQVwvYlUrUitBYkZ1NWZjSVAwdmNvRDZiSlp0ZHZwTCtYaDZlcE14Rlgyd1wvZFV5U3RPR3V5In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/ixgbe: fix x550 code to handle unidentified PHY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 17:41:12 -0000 > -----Original Message----- > From: Luca Boccassi [mailto:bluca@debian.org] > Sent: Friday, November 2, 2018 8:19 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Qi Z ; > 3chas3@gmail.com; Luca Boccassi ; stable@dpdk.org > Subject: [PATCH v3 1/2] net/ixgbe: fix x550 code to handle unidentified P= HY >=20 > ixgbe_identify_sfp_module_X550em() was missing the code to handle > unidentified PHY that has been there in 82599 so it was not able to compl= ete > initialization of ixgbe sequence if no sfp plugged in. > Port it over to return an appropriate type and complete init sequence > properly. >=20 > Fixes: d2e72774e58c ("ixgbe/base: support X550") > Cc: stable@dpdk.org >=20 > Signed-off-by: Luca Boccassi > --- > v2: refresh to remove merge conflict with master > v3: coalesce fix into ixgbe_identify_sfp_module_X550em to avoid > code duplication, improve comment >=20 > drivers/net/ixgbe/base/ixgbe_x550.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c > b/drivers/net/ixgbe/base/ixgbe_x550.c > index f7b98af52..a88d5c86a 100644 > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > @@ -1561,6 +1561,12 @@ s32 ixgbe_identify_sfp_module_X550em(struct > ixgbe_hw *hw) >=20 > status =3D ixgbe_identify_module_generic(hw); >=20 > + /* Set PHY type none if no PHY detected to allow init without SFP */ > + if (hw->phy.type =3D=3D ixgbe_phy_unknown) { > + hw->phy.type =3D ixgbe_phy_none; Set PHY type to none for a device that does have PHY looks weird. =20 does ixgeb_phy_generic works here? Where is failure you met with ixgbe_phy_unknown? > + return IXGBE_SUCCESS; > + } > + > if (status !=3D IXGBE_SUCCESS) > return status; >=20 > -- > 2.19.1