From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 038891B209; Wed, 14 Nov 2018 21:16:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2018 12:16:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,233,1539673200"; d="scan'208";a="89316125" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 14 Nov 2018 12:16:31 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 14 Nov 2018 12:16:31 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0415.000; Thu, 15 Nov 2018 04:16:29 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix X710 Rx issue after reading some registers Thread-Index: AQHUe8/fbYmoSl3Wk0K2REe8x+cFeaVPtNeQ Date: Wed, 14 Nov 2018 20:16:29 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532E4011@SHSMSX103.ccr.corp.intel.com> References: <1542168638-59416-1-git-send-email-beilei.xing@intel.com> In-Reply-To: <1542168638-59416-1-git-send-email-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGMyZjYyZGYtNzNmYS00Yzk5LWEwOTItN2ZhYjZjYjk1MDA2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUmkrRXhGNVhBWjlrbVB1clhcLzM0VGhZY3BSNUI5RHVTOE5qOGhmbDVxMTFWSFN5bjR1SUtTOVdqamFSTGdXKzkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix X710 Rx issue after reading some registers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 20:16:38 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Tuesday, November 13, 2018 8:11 PM > To: Zhang, Qi Z ; Wu, Jingjing > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/i40e: fix X710 Rx issue after reading some registers >=20 > There's an issue that X710 can't receive any packet after reading some sp= ecial > registers. That's because these registers are only valid for X722, read a= ccess for > non-X722 will cause ECC error. >=20 > Fixes: d9efd0136ac1 ("i40e: add EEPROM and registers dumping") > Cc: stable@dpdk.org >=20 > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_ethdev.c | 33 > +++++++++++++++++++++++++++++++-- > 1 file changed, 31 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 1c77906..686227e 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -11609,6 +11609,31 @@ i40e_dev_rx_queue_intr_disable(struct > rte_eth_dev *dev, uint16_t queue_id) > return 0; > } >=20 > +/** > + * This function is used to check if the register is valid for non-X722 = NIC. > + * Below is the valid registers list for X722 only: > + * 0x2b800--0x2bb00 > + * 0x38700--0x38a00 > + * 0x3d800--0x3db00 > + * 0x208e00--0x209000 > + * 0x20be00--0x20c000 > + * 0x263c00--0x264000 > + * 0x265c00--0x266000 > + */ > +static inline int i40e_valid_regs(uint32_t reg_offset) { The function is named as "i4Oe_xxx", but actually it is for all devices. I think it will be better either move the mac_type check into the function = or rename to a more specific function name. > + if (((reg_offset >=3D 0x2b800) && (reg_offset <=3D 0x2bb00)) || > + ((reg_offset >=3D 0x38700) && (reg_offset <=3D 0x38a00)) || > + ((reg_offset >=3D 0x3d800) && (reg_offset <=3D 0x3db00)) || > + ((reg_offset >=3D 0x208e00) && (reg_offset <=3D 0x209000)) || > + ((reg_offset >=3D 0x20be00) && (reg_offset <=3D 0x20c000)) || > + ((reg_offset >=3D 0x263c00) && (reg_offset <=3D 0x264000)) || > + ((reg_offset >=3D 0x265c00) && (reg_offset <=3D 0x266000))) > + return 0; > + else > + return 1; > +} > + > static int i40e_get_regs(struct rte_eth_dev *dev, > struct rte_dev_reg_info *regs) > { > @@ -11650,8 +11675,12 @@ static int i40e_get_regs(struct rte_eth_dev > *dev, > reg_offset =3D arr_idx * reg_info->stride1 + > arr_idx2 * reg_info->stride2; > reg_offset +=3D reg_info->base_addr; > - ptr_data[reg_offset >> 2] =3D > - I40E_READ_REG(hw, reg_offset); > + if ((hw->mac.type !=3D I40E_MAC_X722) && > + !i40e_valid_regs(reg_offset)) > + ptr_data[reg_offset >> 2] =3D 0; > + else > + ptr_data[reg_offset >> 2] =3D > + I40E_READ_REG(hw, reg_offset); > } > } >=20 > -- > 2.5.5