From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7E39691 for ; Thu, 15 Nov 2018 19:07:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2018 10:07:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,237,1539673200"; d="scan'208";a="91429496" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 15 Nov 2018 10:07:19 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 15 Nov 2018 10:07:17 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 15 Nov 2018 10:07:16 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0415.000; Fri, 16 Nov 2018 02:07:15 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "Peng, Yuan" Thread-Topic: [PATCH] net/i40e: fix RSS key pointer initialization error Thread-Index: AQHUfMSoN+ftBLfOLE6yJ4c5GUBeaqVQEtGAgAEOV1A= Date: Thu, 15 Nov 2018 18:07:14 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532E4891@SHSMSX103.ccr.corp.intel.com> References: <1542272240-24905-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGIzMmI2OWUtZTBkMC00NWUzLTg5Y2QtNDUyYWY1ZTY5ZDlkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUTF5TURDUk8wK0tEVnBYNUtQajlsSXBnbUl5UG5XXC83ajJleCsxTnV5cmhIK21odVVoN0hNdTNRSVM4Z2pjYjIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix RSS key pointer initialization error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 18:07:22 -0000 > -----Original Message----- > From: Zhao1, Wei > Sent: Thursday, November 15, 2018 1:55 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Peng, Yuan > Subject: RE: [PATCH] net/i40e: fix RSS key pointer initialization error >=20 > Send on behalf of Peng, Yuan >=20 > tested-by: Peng, Yuan Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi >=20 > - Tested Branch: master > - Tested Commit: 3e42b6ce06a1901b1ab631df4484ec8f548091c6 > - OS: 4.5.5-300.fc24.x86_64 > - GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) > - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz > - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection > [8086:10fb] (rev 01) > Intel Corporation Ethernet Controller X710 for 10GbE SFP+ [8086:1572= ] > (rev 01) > - Default x86_64-native-linuxapp-gcc configuration > - Prerequisites: > - Total 1 cases, 1 passed, 0 failed >=20 > - Case: > ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 > 05:00.1 ./x86_64-native-linuxapp-gcc/app/testpmd -c 1ffff -n 4 - -i > --nb-cores=3D8 --rxq=3D4 --txq=3D4 --port-topology=3Dchained > testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp > testpmd> end key 67108863 / end > Flow rule #0 created > testpmd> flow flush 0 > testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp > testpmd> end / end > Flow rule #0 created >=20 >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Thursday, November 15, 2018 4:57 PM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z ; Peng, Yuan > > ; Zhao1, Wei > > Subject: [PATCH] net/i40e: fix RSS key pointer initialization error > > > > The assignment should be done after initialization, or it will be zero. > > > > Fixes: 264b23e3d2c1 ("net/i40e: add parameter check for RSS flow > > init") > > > > Signed-off-by: Wei Zhao > > --- > > drivers/net/i40e/i40e_ethdev.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 790ecc3..a96d407 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -12554,8 +12554,6 @@ i40e_rss_conf_init(struct > > i40e_rte_flow_rss_conf *out, > > return -EINVAL; > > if (!in->key && in->key_len) > > return -EINVAL; > > - if (in->key) > > - out->conf.key =3D memcpy(out->key, in->key, in->key_len); > > out->conf =3D (struct rte_flow_action_rss){ > > .func =3D in->func, > > .level =3D in->level, > > @@ -12565,6 +12563,8 @@ i40e_rss_conf_init(struct > > i40e_rte_flow_rss_conf *out, > > .queue =3D memcpy(out->queue, in->queue, > > sizeof(*in->queue) * in->queue_num), > > }; > > + if (in->key) > > + out->conf.key =3D memcpy(out->key, in->key, in->key_len); > > return 0; > > } > > > > -- > > 2.7.5