DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/ixgbe: update the maximum wait time in comment
@ 2018-11-15  7:20 Xiaolong Ye
  2018-11-15 18:10 ` Zhang, Qi Z
  0 siblings, 1 reply; 2+ messages in thread
From: Xiaolong Ye @ 2018-11-15  7:20 UTC (permalink / raw)
  To: Qi Zhang, Beilei Xing; +Cc: dev, stable, Xiaolong Ye, mgsmith

As the code has changed the max wait time to 1000ms, the comment should
be changed accordingly.

Fixes: 64f1c8539c8c ("net/ixgbe: wait longer for link after fiber MAC setup")
Cc: mgsmith@netgate.com
Cc: stable@dpdk.org

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 drivers/net/ixgbe/base/ixgbe_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c
index 21f973e5e..fb50719fb 100644
--- a/drivers/net/ixgbe/base/ixgbe_common.c
+++ b/drivers/net/ixgbe/base/ixgbe_common.c
@@ -5259,7 +5259,7 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,
 		ixgbe_flap_tx_laser(hw);
 
 		/* Wait for the controller to acquire link.  Per IEEE 802.3ap,
-		 * Section 73.10.2, we may have to wait up to 500ms if KR is
+		 * Section 73.10.2, we may have to wait up to 1000ms if KR is
 		 * attempted.  82599 uses the same timing for 10g SFI.
 		 */
 		for (i = 0; i < 10; i++) {
-- 
2.17.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/ixgbe: update the maximum wait time in comment
  2018-11-15  7:20 [dpdk-dev] [PATCH] net/ixgbe: update the maximum wait time in comment Xiaolong Ye
@ 2018-11-15 18:10 ` Zhang, Qi Z
  0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2018-11-15 18:10 UTC (permalink / raw)
  To: Ye, Xiaolong, Xing, Beilei; +Cc: dev, stable, mgsmith



> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Wednesday, November 14, 2018 11:20 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>;
> mgsmith@netgate.com
> Subject: [PATCH] net/ixgbe: update the maximum wait time in comment
> 
> As the code has changed the max wait time to 1000ms, the comment should be
> changed accordingly.
> 
> Fixes: 64f1c8539c8c ("net/ixgbe: wait longer for link after fiber MAC setup")
> Cc: mgsmith@netgate.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-15 18:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15  7:20 [dpdk-dev] [PATCH] net/ixgbe: update the maximum wait time in comment Xiaolong Ye
2018-11-15 18:10 ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).