From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wu, Yanglong" <yanglong.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix TDH register setting issue
Date: Tue, 20 Nov 2018 19:49:52 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532E8C2D@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181120055921.8209-1-yanglong.wu@intel.com>
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Monday, November 19, 2018 9:59 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Wu, Yanglong <yanglong.wu@intel.com>
> Subject: [PATCH v2] net/ixgbe: fix TDH register setting issue
>
> The only time that software should write to the TDH register is after a reset
> (hardware reset or CTRL.RST) and before enabling the transmit function
> (TXDCTL.ENABLE).
> If software were to write to this register while the transmit function was
> enabled, the on-chip descriptor buffers might be invalidated and the hardware
> could become confused.
>
> cc stable@dpdk.org
Cc: stable@dpdk.org
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel with adding below fix line
Fixes: 029fd06d40fa ("ixgbe: queue start and stop")
Thanks
Qi
prev parent reply other threads:[~2018-11-20 19:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 2:32 [dpdk-dev] [PATCH] " Yanglong Wu
2018-11-16 19:51 ` Zhang, Qi Z
2018-11-20 2:11 ` Wu, Yanglong
2018-11-20 6:02 ` Zhang, Qi Z
2018-11-20 5:59 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-11-20 19:49 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532E8C2D@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=yanglong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).