From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1C3B01B5CA for ; Fri, 23 Nov 2018 20:17:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Nov 2018 11:17:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,270,1539673200"; d="scan'208";a="88684052" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 23 Nov 2018 11:17:20 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 23 Nov 2018 11:17:20 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.199]) with mapi id 14.03.0415.000; Sat, 24 Nov 2018 03:17:18 +0800 From: "Zhang, Qi Z" To: "Stojaczyk, Dariusz" , "dev@dpdk.org" CC: "thomas@monjalon.net" Thread-Topic: [PATCH] dev: fix devargs memleak on IPC detach request Thread-Index: AQHUgzhJvpIOZm1BTUKwro61LmOjDqVdu0iQ Date: Fri, 23 Nov 2018 19:17:18 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532EA1E6@SHSMSX103.ccr.corp.intel.com> References: <20181123141107.86553-1-dariusz.stojaczyk@intel.com> In-Reply-To: <20181123141107.86553-1-dariusz.stojaczyk@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTE1Yjc5MDUtY2ZkMi00ODZiLWEwZDQtNTU5ODk5ZjZlMDgxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRHU3YnN2NG14NHdSbExmV3dQZWRHaHN3YXBLNCtxdnliSkNnbGNwelZ6bkw2WGcrajd3Q2xpY01nZ1g5MlN6aCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] dev: fix devargs memleak on IPC detach request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 19:17:22 -0000 > -----Original Message----- > From: Stojaczyk, Dariusz > Sent: Friday, November 23, 2018 6:11 AM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Stojaczyk, Dariusz = ; > Zhang, Qi Z > Subject: [PATCH] dev: fix devargs memleak on IPC detach request >=20 > Device detach triggered through IPC leaked some memory. > It allocated a devargs objects just to use it for parsing the devargs str= ing in order > to retrieve the device name. Those devargs weren't passed anywhere and we= re > never freed. >=20 > First of all, let's put those devargs on the stack, so they doesn't need = to be freed. > Then free the additional arguments string as soon as it's allocated, beca= use we > won't need it. >=20 > Fixes: ac9e4a17370f ("eal: support attach/detach shared device from > secondary") > Cc: qi.z.zhang@intel.com >=20 > Signed-off-by: Darek Stojaczyk Acked-by: Qi Zhang Thanks Qi