From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2AF2A1B4B6 for ; Thu, 13 Dec 2018 10:10:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 01:10:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,348,1539673200"; d="scan'208";a="303475136" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 13 Dec 2018 01:10:29 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 01:10:28 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.59]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0415.000; Thu, 13 Dec 2018 17:10:26 +0800 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Yang, Qiming" , "Li, Xiaoyun" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v3 18/34] net/ice: support getting device information Thread-Index: AQHUkehf/LoWmXMv1UO60OOZwLuO46V8YZwA Date: Thu, 13 Dec 2018 09:10:26 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532FE524@SHSMSX103.ccr.corp.intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-19-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1544598004-27099-19-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmZiMmEzMTQtNGZjZi00ZmQwLThjNjEtZjJjZjQ3ZGM0YWUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRWFoMzFTZ2tPemVsNGtzTnQrZGtmN0loQzVaWGpyVDVjQm1RXC8xemdjMlVuZjYwNlRSY3ZCMFZhVFBxMDdheDIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 18/34] net/ice: support getting device information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 09:10:34 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Wednesday, December 12, 2018 3:00 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Li, Xiaoyun ; Wu, Jingjing > > Subject: [dpdk-dev] [PATCH v3 18/34] net/ice: support getting device > information >=20 > Add ops dev_infos_get. >=20 > Signed-off-by: Wenzhuo Lu > Signed-off-by: Qiming Yang > Signed-off-by: Xiaoyun Li > Signed-off-by: Jingjing Wu > --- > drivers/net/ice/ice_ethdev.c | 123 > +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 123 insertions(+) >=20 > } > + > +static void > +ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info > +*dev_info) { > + struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); > + struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + struct ice_vsi *vsi =3D pf->main_vsi; > + struct rte_pci_device *pci_dev =3D RTE_DEV_TO_PCI(dev->device); > + > + dev_info->min_rx_bufsize =3D ICE_BUF_SIZE_MIN; > + dev_info->max_rx_pktlen =3D ICE_FRAME_SIZE_MAX; > + dev_info->max_rx_queues =3D vsi->nb_qps; > + dev_info->max_tx_queues =3D vsi->nb_qps; > + dev_info->max_mac_addrs =3D vsi->max_macaddrs; > + dev_info->max_vfs =3D pci_dev->max_vfs; > + > + dev_info->rx_offload_capa =3D > + DEV_RX_OFFLOAD_VLAN_STRIP | > + DEV_RX_OFFLOAD_IPV4_CKSUM | > + DEV_RX_OFFLOAD_UDP_CKSUM | > + DEV_RX_OFFLOAD_TCP_CKSUM | > + DEV_RX_OFFLOAD_QINQ_STRIP | > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > + DEV_RX_OFFLOAD_VLAN_EXTEND | > + DEV_RX_OFFLOAD_JUMBO_FRAME; I think we missed some offload here which ice driver does support=20 Rx port offload DEV_RX_OFFLOAD_KEEP_CRC DEV_RX_OFFLOAD_SCATTER DEV_RX_OFFLOAD_VLAN_FILTER Tx queue offload DEV_TX_OFFLOAD_MBUF_FAST_FREE > + dev_info->tx_offload_capa =3D > + DEV_TX_OFFLOAD_VLAN_INSERT | > + DEV_TX_OFFLOAD_QINQ_INSERT | > + DEV_TX_OFFLOAD_IPV4_CKSUM | > + DEV_TX_OFFLOAD_UDP_CKSUM | > + DEV_TX_OFFLOAD_TCP_CKSUM | > + DEV_TX_OFFLOAD_SCTP_CKSUM | > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | > + DEV_TX_OFFLOAD_TCP_TSO; > + dev_info->rx_queue_offload_capa =3D 0; > + dev_info->tx_queue_offload_capa =3D 0; > +