From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B4BAB5942; Thu, 13 Dec 2018 10:47:12 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 01:47:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,348,1539673200"; d="scan'208";a="129588980" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 13 Dec 2018 01:47:11 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 01:47:11 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 01:47:10 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.59]) by shsmsx102.ccr.corp.intel.com ([169.254.2.182]) with mapi id 14.03.0415.000; Thu, 13 Dec 2018 17:47:09 +0800 From: "Zhang, Qi Z" To: Didier Pallard , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: revert fix offload not supported mask Thread-Index: AQHUkXaSZ0c5AXJ6W0KfbemFK+ruMaV8bodw Date: Thu, 13 Dec 2018 09:47:08 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532FE57A@SHSMSX103.ccr.corp.intel.com> References: <20181211172501.31467-1-didier.pallard@6wind.com> In-Reply-To: <20181211172501.31467-1-didier.pallard@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTg1YzNiYzEtNmU1NC00NTlmLTkyODAtOGU2YmVkOTFjZjM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTXNtRTN0T3RFSllONkVXOGxPdEQ0WW5vZzdnUWZpcGhzeWptcUFcL1wvTzRHckFsNUZzRTFqb2xOSEpoYks0WnpoIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: revert fix offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 09:47:13 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Didier Pallard > Sent: Wednesday, December 12, 2018 1:25 AM > To: dev@dpdk.org > Cc: stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: revert fix offload not supported ma= sk >=20 > This reverts > commit 09a62d75691f ("net/i40e: fix offload not supported mask") >=20 > Contrary to what is said in above patch commit log, > I40E_TX_OFFLOAD_NOTSUP_MASK is the mask of Tx offload bits that are part = of > PKT_TX_OFFLOAD_MASK but not included in I40E_TX_OFFLOAD_MASK. > Above patch erroneously includes all PKT_RX_OFFLOAD_ bits in the > I40E_TX_OFFLOAD_NOTSUP_MASK, this is not what is expected. > Restore the initial xor that gives the expected result. >=20 > Fixes: 09a62d75691f ("net/i40e: fix offload not supported mask") > Cc: stable@dpdk.org > Signed-off-by: Didier Pallard Acked-by: Qi Zhang Applied to dpdk-next-net-intel Thanks Qi