From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5A6E01B4C0 for ; Thu, 13 Dec 2018 10:57:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 01:57:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,348,1539673200"; d="scan'208";a="110046008" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 13 Dec 2018 01:57:44 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 01:57:43 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.59]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.222]) with mapi id 14.03.0415.000; Thu, 13 Dec 2018 17:57:41 +0800 From: "Zhang, Qi Z" To: "Yan, Zhirun" , "dev@dpdk.org" CC: "Wang, Haiyue" Thread-Topic: [PATCH v2] net/i40e: remove redundant code Thread-Index: AQHUkqJqtqcs/cmZr02Nyiu/RVntGaV8byFQ Date: Thu, 13 Dec 2018 09:57:41 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532FE597@SHSMSX103.ccr.corp.intel.com> References: <20181210133205.70401-1-zhirun.yan@intel.com> <20181213124928.25154-1-zhirun.yan@intel.com> In-Reply-To: <20181213124928.25154-1-zhirun.yan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTIzZjA3ODktZjAxNS00MTlhLWIxNjctOWQ3NmE1OWM4YzYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK1FpZk40NTQ4Z0N2WlEwYmlmUHd0UDVlb0l3WnBcL3B5WGw4ZFp4Y3VVUWRaMjJyeEQxbjB6M3VyQW5XajRZZFMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: remove redundant code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 09:57:45 -0000 > -----Original Message----- > From: Yan, Zhirun > Sent: Thursday, December 13, 2018 8:49 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Yan, Zhirun ; Wang, Haiyue > Subject: [PATCH v2] net/i40e: remove redundant code >=20 > Before this patch, there are two functions will call i40e_dev_free_queues= to free > queues. For rte_eth_dev_close(), its redundant because of duplication. Fo= r > rte_eth_dev_reset() its redundant because of not necessary, since followi= ng > dev_configure is required after dev_reset and it will be updated correctl= y. >=20 > This patch removes redundant code in i40e_dev_free_queues(). >=20 > Fixes: 6b4537128394 ("i40e: free queue memory when closing") >=20 > Signed-off-by: Zhirun Yan > Signed-off-by: Haiyue Wang Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi