From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7756B2BE1 for ; Thu, 13 Dec 2018 13:06:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 04:06:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,348,1539673200"; d="scan'208";a="110071023" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 13 Dec 2018 04:06:32 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 04:06:31 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 04:06:31 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.59]) by shsmsx102.ccr.corp.intel.com ([169.254.2.182]) with mapi id 14.03.0415.000; Thu, 13 Dec 2018 20:06:29 +0800 From: "Zhang, Qi Z" To: Leonid Myravjev , "Lu, Wenzhuo" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added. Thread-Index: AQHUjJcSPqtqESSk5E6glzK7+NkMF6V8nnGA Date: Thu, 13 Dec 2018 12:06:29 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532FE69B@SHSMSX103.ccr.corp.intel.com> References: <20181205123514.7104-1-asm@asm.pp.ru> In-Reply-To: <20181205123514.7104-1-asm@asm.pp.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGQzMjRjMTQtYzMxMC00NzIwLTg0NTEtNWMyYTFhODM1MjI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU1RhRW12N2N4Qkg0eWhQYVhPQnpoeU9VVWZubFoxUEdpZGZIR1wvXC9OTVZZSlI1S253RllEb0lzOEhYU3kxYmQyIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 12:06:34 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Leonid Myravjev > Sent: Wednesday, December 5, 2018 8:35 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Leonid Myravjev > Subject: [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register ad= ded. >=20 > Signed-off-by: Leonid Myravjev > --- > drivers/net/e1000/igb_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethde= v.c > index d9d29d22f..ebc242cd9 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -458,6 +458,7 @@ struct rte_igb_xstats_name_off { static const struct > rte_igb_xstats_name_off rte_igb_stats_strings[] =3D { > {"rx_crc_errors", offsetof(struct e1000_hw_stats, crcerrs)}, > {"rx_align_errors", offsetof(struct e1000_hw_stats, algnerrc)}, > + {"rx_rx_errors", offsetof(struct e1000_hw_stats, rxerrc)}, I have no objection for this change, I just feel add all missing field (tha= t be read from register in igb_read_stats_registers) in this array makes th= e patch complete. Would do you think? > {"rx_symbol_errors", offsetof(struct e1000_hw_stats, symerrs)}, > {"rx_missed_packets", offsetof(struct e1000_hw_stats, mpc)}, > {"tx_single_collision_packets", offsetof(struct e1000_hw_stats, scc)}, > -- > 2.17.1