* [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added.
@ 2018-12-05 12:35 Leonid Myravjev
2018-12-13 12:06 ` Zhang, Qi Z
0 siblings, 1 reply; 2+ messages in thread
From: Leonid Myravjev @ 2018-12-05 12:35 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: dev, Leonid Myravjev
Signed-off-by: Leonid Myravjev <asm@asm.pp.ru>
---
drivers/net/e1000/igb_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index d9d29d22f..ebc242cd9 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -458,6 +458,7 @@ struct rte_igb_xstats_name_off {
static const struct rte_igb_xstats_name_off rte_igb_stats_strings[] = {
{"rx_crc_errors", offsetof(struct e1000_hw_stats, crcerrs)},
{"rx_align_errors", offsetof(struct e1000_hw_stats, algnerrc)},
+ {"rx_rx_errors", offsetof(struct e1000_hw_stats, rxerrc)},
{"rx_symbol_errors", offsetof(struct e1000_hw_stats, symerrs)},
{"rx_missed_packets", offsetof(struct e1000_hw_stats, mpc)},
{"tx_single_collision_packets", offsetof(struct e1000_hw_stats, scc)},
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added.
2018-12-05 12:35 [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added Leonid Myravjev
@ 2018-12-13 12:06 ` Zhang, Qi Z
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2018-12-13 12:06 UTC (permalink / raw)
To: Leonid Myravjev, Lu, Wenzhuo; +Cc: dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Leonid Myravjev
> Sent: Wednesday, December 5, 2018 8:35 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Leonid Myravjev <asm@asm.pp.ru>
> Subject: [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added.
>
> Signed-off-by: Leonid Myravjev <asm@asm.pp.ru>
> ---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index d9d29d22f..ebc242cd9 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -458,6 +458,7 @@ struct rte_igb_xstats_name_off { static const struct
> rte_igb_xstats_name_off rte_igb_stats_strings[] = {
> {"rx_crc_errors", offsetof(struct e1000_hw_stats, crcerrs)},
> {"rx_align_errors", offsetof(struct e1000_hw_stats, algnerrc)},
> + {"rx_rx_errors", offsetof(struct e1000_hw_stats, rxerrc)},
I have no objection for this change, I just feel add all missing field (that be read from register in igb_read_stats_registers) in this array makes the patch complete.
Would do you think?
> {"rx_symbol_errors", offsetof(struct e1000_hw_stats, symerrs)},
> {"rx_missed_packets", offsetof(struct e1000_hw_stats, mpc)},
> {"tx_single_collision_packets", offsetof(struct e1000_hw_stats, scc)},
> --
> 2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-13 12:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-05 12:35 [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added Leonid Myravjev
2018-12-13 12:06 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).