From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id E3EE41B60B for ; Fri, 14 Dec 2018 03:43:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 18:43:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,351,1539673200"; d="scan'208";a="259361708" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 13 Dec 2018 18:43:32 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 18:43:32 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 18:43:31 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.59]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.203]) with mapi id 14.03.0415.000; Fri, 14 Dec 2018 10:43:28 +0800 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Yang, Qiming" , "Li, Xiaoyun" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update Thread-Index: AQHUkeh5aRSwCxZ9lka0OouinFWNHKV8XDtggACD3ACAAKiPQA== Date: Fri, 14 Dec 2018 02:43:27 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532FEB6D@SHSMSX103.ccr.corp.intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-21-git-send-email-wenzhuo.lu@intel.com> <039ED4275CED7440929022BC67E70611532FE4DA@SHSMSX103.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093FE13DF0@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093FE13DF0@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDI4MDJmZWEtNTVjZS00ZDQ3LWE5ZWYtNWEwOWU4Yzk5NzU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMXJGb2RsVnlzcFdrSXMxKzd2bENCelVNdlpiUXdZMnBkQnhGekszSHVNTndRU0d4bVM1ektXeEM3UTBFaDlBNyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 02:43:34 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Friday, December 14, 2018 8:36 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Yang, Qiming ; Li, Xiaoyun ; > Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update >=20 > Hi Qi, >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Thursday, December 13, 2018 4:47 PM > > To: Lu, Wenzhuo ; dev@dpdk.org > > Cc: Lu, Wenzhuo ; Yang, Qiming > > ; Li, Xiaoyun ; Wu, > > Jingjing > > Subject: RE: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update > > > > Hi Wenzhuo: > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > > Sent: Wednesday, December 12, 2018 3:00 PM > > > To: dev@dpdk.org > > > Cc: Lu, Wenzhuo ; Yang, Qiming > > > ; Li, Xiaoyun ; Wu, > > > Jingjing > > > Subject: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update > > > > > > Add ops link_update. > > > > > > > +ice_interrupt_handler(void *param) > > > +{ > > > + struct rte_eth_dev *dev =3D (struct rte_eth_dev *)param; > > > + struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > > >dev_private); > > > + uint32_t oicr; > > > > I saw the patch also enabled interrupt handler, which looks like be > > independent and not related with the commit log. > > It's better to separate it. > Here we only enable LSC interrupt for link update. So, I prefer putting i= t in this > patch. OK, I will suggest to modify the commit log to include the LSC part, since = enable LSC is different with add ops link_update.