From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 4ED581B5CC for ; Tue, 18 Dec 2018 13:44:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2018 04:44:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,368,1539673200"; d="scan'208";a="110360580" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 18 Dec 2018 04:44:21 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 18 Dec 2018 04:44:21 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.59]) by shsmsx102.ccr.corp.intel.com ([169.254.2.182]) with mapi id 14.03.0415.000; Tue, 18 Dec 2018 20:44:19 +0800 From: "Zhang, Qi Z" To: "Yan, Zhirun" , "dev@dpdk.org" CC: "Wang, Haiyue" Thread-Topic: [PATCH v6 1/3] net/i40e: support VF request more queues Thread-Index: AQHUlqxFQ3NP0O6F3Uuti3XSdKwK9aWEcTPg Date: Tue, 18 Dec 2018 12:44:18 +0000 Message-ID: <039ED4275CED7440929022BC67E706115330204F@SHSMSX103.ccr.corp.intel.com> References: <20181217111054.45414-1-zhirun.yan@intel.com> <20181218160933.11113-1-zhirun.yan@intel.com> <20181218160933.11113-2-zhirun.yan@intel.com> In-Reply-To: <20181218160933.11113-2-zhirun.yan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTRjMTNlY2YtYzVkZC00OGRhLThhYjMtOGVkMzI5ZGRiMDUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibE1QY3g3b1dUeG11eGlxUU9WdFwvR2d2M1M3UHJRXC9aeWdIUjZFSzRZbEJVSGo4eWpSQng3SDdLVXZLd0ZEWVlLIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/3] net/i40e: support VF request more queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 12:44:23 -0000 > -----Original Message----- > From: Yan, Zhirun > Sent: Wednesday, December 19, 2018 12:10 AM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Yan, Zhirun ; Wang, Haiyue > Subject: [PATCH v6 1/3] net/i40e: support VF request more queues >=20 > Before this patch, VF gets a default number of queues from the PF. > This patch enables VF to request a different number. When VF configures m= ore > queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF to request more > queues, if success, PF will reset the VF. >=20 > User can run "port stop all", "port config port_id rxq/txq queue_num" > and "port start all" to reconfigure queue number. >=20 > Signed-off-by: Zhirun Yan > Signed-off-by: Haiyue Wang > --- > drivers/net/i40e/i40e_ethdev_vf.c | 62 ++++++++++++++++++++++++++++++- > 1 file changed, 60 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index 05dc6596b..498e86649 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -359,6 +359,25 @@ i40evf_execute_vf_cmd(struct rte_eth_dev *dev, struc= t > vf_cmd_info *args) > } while (i++ < MAX_TRY_TIMES); > _clear_cmd(vf); > break; > + case VIRTCHNL_OP_REQUEST_QUEUES: > + /*ignore async reply, only wait for system message,*/ > + /*vf_reset =3D true if get VIRTCHNL_EVENT_RESET_IMPENDING,*/ > + /*if not, means request queues failed */ I think you forgot to fix the comment format as Ferruh mentioned previously > + err =3D -1; > + do { > + ret =3D i40evf_read_pfmsg(dev, &info); > + vf->cmd_retval =3D info.result; > + if (ret =3D=3D I40EVF_MSG_SYS && vf->vf_reset) { > + err =3D 0; > + break; > + } else if (ret =3D=3D I40EVF_MSG_ERR || ret =3D=3D I40EVF_MSG_CMD) { > + break; > + } > + rte_delay_ms(ASQ_DELAY_MS); > + /* If don't read msg or read sys event, continue */ > + } while (i++ < MAX_TRY_TIMES); > + _clear_cmd(vf); > + break; >=20 > default: > /* for other adminq in running time, waiting the cmd done flag */ @@ > -1012,6 +1031,28 @@ i40evf_add_vlan(struct rte_eth_dev *dev, uint16_t vla= nid) > return err; > } >=20 > +static int > +i40evf_request_queues(struct rte_eth_dev *dev, uint16_t num) { > + struct i40e_vf *vf =3D > I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > + struct virtchnl_vf_res_request vfres; > + struct vf_cmd_info args; > + int err; > + > + vfres.num_queue_pairs =3D num; > + > + args.ops =3D VIRTCHNL_OP_REQUEST_QUEUES; > + args.in_args =3D (u8 *)&vfres; > + args.in_args_size =3D sizeof(vfres); > + args.out_buffer =3D vf->aq_resp; > + args.out_size =3D I40E_AQ_BUF_SZ; > + err =3D i40evf_execute_vf_cmd(dev, &args); > + if (err) > + PMD_DRV_LOG(ERR, "fail to execute command > OP_REQUEST_QUEUES"); > + > + return err; > +} > + > static int > i40evf_del_vlan(struct rte_eth_dev *dev, uint16_t vlanid) { @@ -1516,8 > +1557,11 @@ RTE_PMD_REGISTER_KMOD_DEP(net_i40e_vf, "* igb_uio | > vfio-pci"); static int i40evf_dev_configure(struct rte_eth_dev *dev) { > + struct i40e_vf *vf =3D > I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > struct i40e_adapter *ad =3D > I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > + uint16_t num_queue_pairs =3D RTE_MAX(dev->data->nb_rx_queues, > + dev->data->nb_tx_queues); >=20 > /* Initialize to TRUE. If any of Rx queues doesn't meet the bulk > * allocation or vector Rx preconditions we will reset it. > @@ -1527,6 +1571,20 @@ i40evf_dev_configure(struct rte_eth_dev *dev) > ad->tx_simple_allowed =3D true; > ad->tx_vec_allowed =3D true; >=20 > + if (num_queue_pairs > vf->vsi_res->num_queue_pairs) { > + int ret =3D 0; > + > + PMD_DRV_LOG(INFO, "change queue pairs from %u to %u", > + vf->vsi_res->num_queue_pairs, num_queue_pairs); > + ret =3D i40evf_request_queues(dev, num_queue_pairs); > + if (ret !=3D 0) > + return ret; > + > + ret =3D i40evf_dev_reset(dev); > + if (ret !=3D 0) > + return ret; > + } > + > return i40evf_init_vlan(dev); > } >=20 > @@ -2145,8 +2203,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) { > struct i40e_vf *vf =3D > I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); >=20 > - dev_info->max_rx_queues =3D vf->vsi_res->num_queue_pairs; > - dev_info->max_tx_queues =3D vf->vsi_res->num_queue_pairs; > + dev_info->max_rx_queues =3D I40E_MAX_QP_NUM_PER_VF; > + dev_info->max_tx_queues =3D I40E_MAX_QP_NUM_PER_VF; > dev_info->min_rx_bufsize =3D I40E_BUF_SIZE_MIN; > dev_info->max_rx_pktlen =3D I40E_FRAME_SIZE_MAX; > dev_info->hash_key_size =3D (I40E_VFQF_HKEY_MAX_INDEX + 1) * > sizeof(uint32_t); > -- > 2.17.1