From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 7126B1B142; Wed, 2 Jan 2019 02:19:04 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jan 2019 17:19:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,429,1539673200"; d="scan'208";a="111436277" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 01 Jan 2019 17:19:03 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 1 Jan 2019 17:19:03 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.150]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.46]) with mapi id 14.03.0415.000; Wed, 2 Jan 2019 09:19:01 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Lu, Wenzhuo" , "Peng, Yuan" Thread-Topic: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter Thread-Index: AQHUnBiNPYfGx6mlOE+p3QwKlp/e4qWbNi3A Date: Wed, 2 Jan 2019 01:19:00 +0000 Message-ID: <039ED4275CED7440929022BC67E706115331096D@SHSMSX103.ccr.corp.intel.com> References: <1545025982-2065-1-git-send-email-wei.zhao1@intel.com> <1545716688-34608-1-git-send-email-wei.zhao1@intel.com> <1545716688-34608-2-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1545716688-34608-2-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTdiMGFhMzEtY2M1OC00ZDM0LThiYWItOTQ1YTgwYjBhNjQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZG0yelpxNXpMajUrOWVodWRVVzlGZmJ5cjc2WmtMdW5pa2Zpc0VIaFhvYThhRG1PeStsMUkwdkJuXC9UYjNsdnQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 01:19:05 -0000 HI Wei: > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, December 25, 2018 1:45 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Lu, Wenzhuo ; Zhang, Qi Z > ; Peng, Yuan ; Zhao1, Wei > > Subject: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter >=20 > There is need for users to use flexible byte filter on x550. > x550 support IP mode and tunnel mode flexible byte filter. > tunnel mode flexible byte filter is used for vxlan packets and so on. It = can be > used combined with FDIR tunnel filter. > By now, ixgbe PMD flow parer code do not support tunnel mode flexible byt= e > filter for x550, So I have to enable it in function ixgbe_parse_fdir_filt= er_tunnel(). > Although IP mode flexible byte filter parser is support in function > ixgbe_parse_fdir_filter_normal(), but some flow like "flow create 0 ingr= ess > pattern raw pattern is 0xab / end actions queue index 3 / end" need to be > support, so parser code also need change a little. > This patch enable all of these feature. I would suggest to divide this patch into 3 patches 1. more accurate input set mask setup (include all changes in ixgbe_fdir.c) 2. support flexbyte without IP layer (include changes in ixgbe_parse_fdir_f= ilter_normal) 3. support flexbyte in tunnel mode (include changes in ixgbe_parse_fdir_fli= lter_tunnel) Btw, please make sure to sync the acceptable flow pattern/action descriptio= n above function ixgbe_parse_fdir_filter_xxxxx to their new behaviors Thanks Qi