From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C34D01B43D; Mon, 7 Jan 2019 09:19:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2019 00:19:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,450,1539673200"; d="scan'208";a="107814209" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 07 Jan 2019 00:19:44 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 7 Jan 2019 00:19:44 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 7 Jan 2019 00:19:43 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.150]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.44]) with mapi id 14.03.0415.000; Mon, 7 Jan 2019 16:19:42 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Wu, Jingjing" Thread-Topic: [PATCH v5] net/ixgbe: fix over using multicast table for VF Thread-Index: AQHUpl1j/2sx5elNd0KLJdNnL1SKCqWjdp7g Date: Mon, 7 Jan 2019 08:19:41 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153316873@SHSMSX103.ccr.corp.intel.com> References: <1546841774-15676-1-git-send-email-wei.zhao1@intel.com> <1546845776-19013-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1546845776-19013-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWY3MGJhZTMtZDI0OC00YTU0LThkODUtMzJkOGMzM2M4MTgzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU0tJcmhrZ0FGcnJnSGMrUjFyNk5ocnJkUjl6dHM2S09vT3JXZWpBYnA2bTQzWDV0eGpIbnVrYjN6NDV5amM5RSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5] net/ixgbe: fix over using multicast table for VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 08:19:46 -0000 > -----Original Message----- > From: Zhao1, Wei > Sent: Monday, January 7, 2019 3:23 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Wu, Jingjing > ; Zhao1, Wei > Subject: [PATCH v5] net/ixgbe: fix over using multicast table for VF >=20 > According to the current implementation, all VFs will set bit > IXGBE_VMOLR_ROMPE during initialization, this cause any VF will accept pa= ckets > that match the MTA table. Since the MTA table is shared by all VFs which = means if > one VF update MTA table in function ixgbe_vf_set_multicast, then all othe= r VFs > will receive multicast packets which cause unnecessary performance overhe= ad. >=20 > So it's better to set VF's ROPE bit of register VMOLR only if multicast a= ddress filter > is required on that VF. > Also, the ROPE bit should be reset when multicast address filter is reque= sted to > clean. >=20 > This patch also aligns to the related fix on ixgbe kernel driver 5.3.7. >=20 > Fixes: 00e30184daa0 ("ixgbe: add PF support") >=20 > Signed-off-by: Wei Zhao Acked-by: Qi Zhang