Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix queue region error in priority configuration

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, January 23, 2019 12:34 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> dev@dpdk.org
> Cc: stable@dpdk.org; Peng, Yuan <yuan.peng@intel.com>
> Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix queue region error in priority
> configuration
> 
> On 1/22/2019 12:48 PM, Zhang, Qi Z wrote:
> >
> >
> >> -----Original Message-----
> >> From: Zhao1, Wei
> >> Sent: Tuesday, January 22, 2019 4:11 PM
> >> To: dev@dpdk.org
> >> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Peng, Yuan
> >> <yuan.peng@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> >> Subject: [PATCH] net/i40e: fix queue region error in priority
> >> configuration
> >
> > Change title to below since it's all about if we need to call
> > i40e_set_dcb_config
> >
> > fix queue region dcb configure
> >
> >
> >>
> >> There is no need to set vlan priority realted resigsters when there
> >> is no configuration about that in queue region.
> >
> > Reword to
> >
> > DCB is not necessary to be configured if no user priority of queue region is
> requested.
> 
> Extended description with provided information as below, please comment if
> change required for this update.
> 
> "
>     DCB is not necessary to be configured if no user priority of
>     queue region is requested.
> 
>     Unexpected configuration of DCB will cause unexpected behavior, like
>     FDIR does not work on those queues, but could cause more issues.
> "

Looks good to me
Thanks
Qi
> 

> >>
> >> Fixes: 7cbecc2f7424 ("net/i40e: support queue region set and flush")
> >> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> > Applied to dpdk-next-net-intel with above change.
> >
> > Thanks
> > Qi
> >