From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ice: enable VLAN filter offloads support
Date: Mon, 18 Feb 2019 12:39:01 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153337258@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1550029788-45809-1-git-send-email-wei.zhao1@intel.com>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, February 13, 2019 11:50 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH v2] net/ice: enable VLAN filter offloads support
I think this is a fix, since vlan filter is already be promised by ice_dev_info_get.
So add below fix line.
Fixes: 690175ee51bf ("net/ice: support getting device information")
>
> There is need to check whether dev_conf.rxmode.offloads is set when start ice
> device, if one of the vlan related bits is set, for example
> DEV_RX_OFFLOAD_VLAN_FILTER and so on, sevice start process to enable this
> offloads request.
Some typo, reword to
VLAN filter is required to be configured during dev_start according to dev_conf.rxmod.offloads
setting, so ice_vlan_offload_set is called to handle this.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel with above changes.
Thanks
Qi
prev parent reply other threads:[~2019-02-18 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 7:53 [dpdk-dev] [PATCH] " Wei Zhao
2019-02-13 3:30 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-02-13 4:05 ` Zhao1, Wei
2019-02-13 3:49 ` Wei Zhao
2019-02-13 18:43 ` Stillwell Jr, Paul M
2019-02-18 12:39 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153337258@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).