From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3D7DA5B3C; Mon, 18 Feb 2019 13:39:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2019 04:39:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,384,1544515200"; d="scan'208";a="127347987" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 18 Feb 2019 04:39:04 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Feb 2019 04:39:03 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Feb 2019 04:39:03 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.194]) by shsmsx102.ccr.corp.intel.com ([169.254.2.207]) with mapi id 14.03.0415.000; Mon, 18 Feb 2019 20:39:01 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] net/ice: enable VLAN filter offloads support Thread-Index: AQHUw1LoBuP3gTp18U2Ab5GjxRd4hqXlg9/A Date: Mon, 18 Feb 2019 12:39:01 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153337258@SHSMSX103.ccr.corp.intel.com> References: <1548662003-7339-1-git-send-email-wei.zhao1@intel.com> <1550029788-45809-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1550029788-45809-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjA1NThjNTQtOTZmMy00MmU0LWI2YzAtZjk4NDlkMWM2YzA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZFlXeHNHRU1pM2NVQWRCZDhqdTlmTUVmdXg0Szl1c0RYVHNiZ0dXU2tMak9XNlpcL3FJVWloRGZUYWZHK0lhM3gifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ice: enable VLAN filter offloads support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2019 12:39:05 -0000 > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, February 13, 2019 11:50 AM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH v2] net/ice: enable VLAN filter offloads support I think this is a fix, since vlan filter is already be promised by ice_dev_= info_get. So add below fix line. Fixes: 690175ee51bf ("net/ice: support getting device information") >=20 > There is need to check whether dev_conf.rxmode.offloads is set when start= ice > device, if one of the vlan related bits is set, for example > DEV_RX_OFFLOAD_VLAN_FILTER and so on, sevice start process to enable this > offloads request. Some typo, reword to VLAN filter is required to be configured during dev_start according to de= v_conf.rxmod.offloads setting, so ice_vlan_offload_set is called to handle this. >=20 > Signed-off-by: Wei Zhao Acked-by: Qi Zhang Applied to dpdk-next-net-intel with above changes. Thanks Qi