From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 734372B9E for ; Fri, 1 Mar 2019 08:45:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2019 23:45:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,426,1544515200"; d="scan'208";a="323141726" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 28 Feb 2019 23:45:04 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Feb 2019 23:45:03 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Feb 2019 23:45:03 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.26]) with mapi id 14.03.0415.000; Fri, 1 Mar 2019 15:45:01 +0800 From: "Zhang, Qi Z" To: Julien Meunier , "Zhao1, Wei" , "Lu, Wenzhuo" , "Ananyev, Konstantin" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 1/2] net/ixgbe: do not start on unsupported loopback mode Thread-Index: AQHUyWALt36Pzid2PEiySF7ta+5dCKX2cmMQ Date: Fri, 1 Mar 2019 07:45:00 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153346B1F@SHSMSX103.ccr.corp.intel.com> References: <20190102160055.30301-1-julien.meunier@nokia.com> <20190220210531.48322-1-julien.meunier@nokia.com> In-Reply-To: <20190220210531.48322-1-julien.meunier@nokia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmQ2MWZiZjEtZmE2Ni00ZDc2LWFhM2EtYWQ3YjVjNjljYzVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib3JiamI3Ym1OWEw1Sk55cUJRK21maWE2VU5TdzVLU251MkV0RnBybzRUU3Vta1RmOGp0dlMxWUJ4NG5pV1piWiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/ixgbe: do not start on unsupported loopback mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 07:45:05 -0000 > -----Original Message----- > From: Julien Meunier [mailto:julien.meunier@nokia.com] > Sent: Thursday, February 21, 2019 5:05 AM > To: Zhao1, Wei ; Zhang, Qi Z ;= Lu, > Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: [PATCH v3 1/2] net/ixgbe: do not start on unsupported loopback m= ode >=20 > Only TX->RX loopback is supported currently on 82599EB. If a user wants t= o apply > an another loopback configuration (!=3D IXGBE_LPBK_82599_TX_RX), ixgbe PM= D > ignores it and continues the configuration without raising any error. >=20 > Let's robustify this part by checking if the requested loopback mode is c= orrect for > the current device, before starting it. If it is not valid, PMD will refu= se to start. >=20 > Signed-off-by: Julien Meunier Acked-by: Wei Zhao Applied to dpdk-next-net-intel. Thanks Qi