From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3E5EA374E for ; Thu, 14 Mar 2019 16:14:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 08:14:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,478,1544515200"; d="scan'208";a="140755774" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 14 Mar 2019 08:14:28 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 08:14:27 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.10]) with mapi id 14.03.0415.000; Thu, 14 Mar 2019 23:14:26 +0800 From: "Zhang, Qi Z" To: "David Harton (dharton)" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf Thread-Index: AQHU1e5mbgVsQvTHBkStQcSkqEbtoaYKpCyAgACQc3A= Date: Thu, 14 Mar 2019 15:14:25 +0000 Message-ID: <039ED4275CED7440929022BC67E706115334CA1F@SHSMSX103.ccr.corp.intel.com> References: <20190306152355.1697-1-dharton@cisco.com> <20190308203430.31742-1-dharton@cisco.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmFmYWIwNzctNWFiYi00MDM0LTg0YWItYzYyYWE1NzcwNTIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ1J0M1Y1TkIrXC9jV2l1Q241enZnbnZsSkt3VUhRaGN2ZFwvMGVIXC80OEJ5NmtlMFo5Z2xFSWYwbmdvcDVscCtzbSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 15:14:29 -0000 > -----Original Message----- > From: David Harton (dharton) [mailto:dharton@cisco.com] > Sent: Thursday, March 14, 2019 9:38 PM > To: David Harton (dharton) ; Zhang, Qi Z > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf >=20 > Hi Qi, >=20 > This patch was rejected with no feedback. >=20 > Can you share why? Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , = ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like VLAN_FILTER AND VLAN_EXTEND offload is not supported and I = didn't see you reply for that, so I assume you agree with that.=20 >=20 > Without this patch users are not able to call the rte_eth_dev_vlan_filter= () API for > ixgbevf based ports because VLAN_FILTER cannot be enabled when calling > rte_eth_dev_configure(). OK, seems vlan filter is able to be configured for ixgbevf, but I don't kno= w how this will work because vlan filter table needs to be enabled first (i= xgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe k= ernel PF driver will enable it by default? Could you share more insight?=20 =20 And same question to VLAN_EXTEND >=20 > Or, am I missing something? >=20 > Thanks, > Dave >=20 > > -----Original Message----- > > From: David Harton > > Sent: Friday, March 08, 2019 3:35 PM > > To: dev@dpdk.org > > Cc: wenzhuo.lu@intel.com; konstantin.ananyev@intel.com; > > qi.z.zhang@intel.com; David Harton (dharton) > > Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf > > > > ixgbevf vlan strip and extend capabilities were removed when migrating > > to the bit flags implementation. > > > > Restoring the capbility to enable these offloads at configuration time. > > > > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > > Signed-off-by: David Harton > > --- > > > > v2: removed unused function ixgbe_is_vf() > > > > drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++--------------------- > > 1 file changed, 2 insertions(+), 21 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter > > *adapter, struct ixgbe_rx_queue *rxq) #endif } > > > > -static int > > -ixgbe_is_vf(struct rte_eth_dev *dev) > > -{ > > - struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data- > > >dev_private); > > - > > - switch (hw->mac.type) { > > - case ixgbe_mac_82599_vf: > > - case ixgbe_mac_X540_vf: > > - case ixgbe_mac_X550_vf: > > - case ixgbe_mac_X550EM_x_vf: > > - case ixgbe_mac_X550EM_a_vf: > > - return 1; > > - default: > > - return 0; > > - } > > -} > > - > > uint64_t > > ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev) { @@ -2853,15 > > +2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev) > > DEV_RX_OFFLOAD_TCP_CKSUM | > > DEV_RX_OFFLOAD_KEEP_CRC | > > DEV_RX_OFFLOAD_JUMBO_FRAME | > > + DEV_RX_OFFLOAD_VLAN_FILTER | > > + DEV_RX_OFFLOAD_VLAN_EXTEND | > > DEV_RX_OFFLOAD_SCATTER; > >=09 > > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; > > > > - if (ixgbe_is_vf(dev) =3D=3D 0) > > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > > - DEV_RX_OFFLOAD_VLAN_EXTEND); > > - > > /* > > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > > IOV > > * mode. > > -- > > 2.19.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2DE60A0096 for ; Thu, 14 Mar 2019 16:14:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 093233772; Thu, 14 Mar 2019 16:14:31 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3E5EA374E for ; Thu, 14 Mar 2019 16:14:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 08:14:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,478,1544515200"; d="scan'208";a="140755774" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 14 Mar 2019 08:14:28 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 08:14:27 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.10]) with mapi id 14.03.0415.000; Thu, 14 Mar 2019 23:14:26 +0800 From: "Zhang, Qi Z" To: "David Harton (dharton)" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf Thread-Index: AQHU1e5mbgVsQvTHBkStQcSkqEbtoaYKpCyAgACQc3A= Date: Thu, 14 Mar 2019 15:14:25 +0000 Message-ID: <039ED4275CED7440929022BC67E706115334CA1F@SHSMSX103.ccr.corp.intel.com> References: <20190306152355.1697-1-dharton@cisco.com> <20190308203430.31742-1-dharton@cisco.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmFmYWIwNzctNWFiYi00MDM0LTg0YWItYzYyYWE1NzcwNTIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ1J0M1Y1TkIrXC9jV2l1Q241enZnbnZsSkt3VUhRaGN2ZFwvMGVIXC80OEJ5NmtlMFo5Z2xFSWYwbmdvcDVscCtzbSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190314151425.-Y68b5zArxhCvmhRbE8p3PeVDqUmXgCOSVZANCyqMzU@z> > -----Original Message----- > From: David Harton (dharton) [mailto:dharton@cisco.com] > Sent: Thursday, March 14, 2019 9:38 PM > To: David Harton (dharton) ; Zhang, Qi Z > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf >=20 > Hi Qi, >=20 > This patch was rejected with no feedback. >=20 > Can you share why? Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , = ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like VLAN_FILTER AND VLAN_EXTEND offload is not supported and I = didn't see you reply for that, so I assume you agree with that.=20 >=20 > Without this patch users are not able to call the rte_eth_dev_vlan_filter= () API for > ixgbevf based ports because VLAN_FILTER cannot be enabled when calling > rte_eth_dev_configure(). OK, seems vlan filter is able to be configured for ixgbevf, but I don't kno= w how this will work because vlan filter table needs to be enabled first (i= xgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe k= ernel PF driver will enable it by default? Could you share more insight?=20 =20 And same question to VLAN_EXTEND >=20 > Or, am I missing something? >=20 > Thanks, > Dave >=20 > > -----Original Message----- > > From: David Harton > > Sent: Friday, March 08, 2019 3:35 PM > > To: dev@dpdk.org > > Cc: wenzhuo.lu@intel.com; konstantin.ananyev@intel.com; > > qi.z.zhang@intel.com; David Harton (dharton) > > Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf > > > > ixgbevf vlan strip and extend capabilities were removed when migrating > > to the bit flags implementation. > > > > Restoring the capbility to enable these offloads at configuration time. > > > > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > > Signed-off-by: David Harton > > --- > > > > v2: removed unused function ixgbe_is_vf() > > > > drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++--------------------- > > 1 file changed, 2 insertions(+), 21 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter > > *adapter, struct ixgbe_rx_queue *rxq) #endif } > > > > -static int > > -ixgbe_is_vf(struct rte_eth_dev *dev) > > -{ > > - struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data- > > >dev_private); > > - > > - switch (hw->mac.type) { > > - case ixgbe_mac_82599_vf: > > - case ixgbe_mac_X540_vf: > > - case ixgbe_mac_X550_vf: > > - case ixgbe_mac_X550EM_x_vf: > > - case ixgbe_mac_X550EM_a_vf: > > - return 1; > > - default: > > - return 0; > > - } > > -} > > - > > uint64_t > > ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev) { @@ -2853,15 > > +2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev) > > DEV_RX_OFFLOAD_TCP_CKSUM | > > DEV_RX_OFFLOAD_KEEP_CRC | > > DEV_RX_OFFLOAD_JUMBO_FRAME | > > + DEV_RX_OFFLOAD_VLAN_FILTER | > > + DEV_RX_OFFLOAD_VLAN_EXTEND | > > DEV_RX_OFFLOAD_SCATTER; > >=09 > > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; > > > > - if (ixgbe_is_vf(dev) =3D=3D 0) > > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > > - DEV_RX_OFFLOAD_VLAN_EXTEND); > > - > > /* > > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > > IOV > > * mode. > > -- > > 2.19.1