From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 240D12C54 for ; Mon, 18 Mar 2019 13:25:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Mar 2019 05:25:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,493,1544515200"; d="scan'208";a="308163062" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 18 Mar 2019 05:25:49 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Mar 2019 05:25:49 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Mar 2019 05:25:48 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.113]) with mapi id 14.03.0415.000; Mon, 18 Mar 2019 20:25:47 +0800 From: "Zhang, Qi Z" To: "Yang, Qiming" , "dev@dpdk.org" Thread-Topic: [PATCH v3 2/5] net/i40e: add support for VXLAN-GPE Thread-Index: AQHU3WNKyUKQ3YQfhk6WgWudC+kWjaYRRO4Q Date: Mon, 18 Mar 2019 12:25:47 +0000 Message-ID: <039ED4275CED7440929022BC67E706115334E4C9@SHSMSX103.ccr.corp.intel.com> References: <20190318133230.140978-1-qiming.yang@intel.com> <20190318154200.28409-1-qiming.yang@intel.com> <20190318154200.28409-3-qiming.yang@intel.com> In-Reply-To: <20190318154200.28409-3-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2M0ZDQ3YzItZDdjYS00ZTNmLWE2Y2YtOTQzYWRkYzBkN2ZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVWpEeG13ZE44SmpzS0J1WXgxNVhuc0l3SzJUT0xmTm05aVAwbWxGMGdMalJjNklBRnJ5bllRNStwN3p1MGJJSSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/5] net/i40e: add support for VXLAN-GPE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2019 12:25:51 -0000 > -----Original Message----- > From: Yang, Qiming > Sent: Monday, March 18, 2019 11:42 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > Subject: [PATCH v3 2/5] net/i40e: add support for VXLAN-GPE >=20 > Can recognize new packet type VXLAN-GPE in i40e driver. > Added inner IP/TCP/UDP checksum and RSS support for VXLAN-GPE packet. The commit log is a missing leading. . there is no inner IP/TCP/UDP checksum and RSS related change May reword to Add new protocol type VXLAN-GPE support for UDP tunnel. inner IP/TCP/UDP checksum and RSS configuration shared the same implementat= ion of VXLAN. >=20 > Signed-off-by: Qiming Yang > --- > drivers/net/i40e/i40e_ethdev.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index dca61f0..b2ec5cc 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -8368,7 +8368,7 @@ i40e_get_vxlan_port_idx(struct i40e_pf *pf, uint16_= t > port) } >=20 > static int > -i40e_add_vxlan_port(struct i40e_pf *pf, uint16_t port) > +i40e_add_vxlan_port(struct i40e_pf *pf, uint16_t port, int udp_type) > { > int idx, ret; > uint8_t filter_idx; > @@ -8391,7 +8391,7 @@ i40e_add_vxlan_port(struct i40e_pf *pf, uint16_t po= rt) > return -ENOSPC; > } >=20 > - ret =3D i40e_aq_add_udp_tunnel(hw, port, > I40E_AQC_TUNNEL_TYPE_VXLAN, > + ret =3D i40e_aq_add_udp_tunnel(hw, port, udp_type, > &filter_idx, NULL); > if (ret < 0) { > PMD_DRV_LOG(ERR, "Failed to add VXLAN UDP port %d", port); @@ > -8459,9 +8459,13 @@ i40e_dev_udp_tunnel_port_add(struct rte_eth_dev *dev, >=20 > switch (udp_tunnel->prot_type) { > case RTE_TUNNEL_TYPE_VXLAN: > - ret =3D i40e_add_vxlan_port(pf, udp_tunnel->udp_port); > + ret =3D i40e_add_vxlan_port(pf, udp_tunnel->udp_port, > + I40E_AQC_TUNNEL_TYPE_VXLAN); > + break; > + case RTE_TUNNEL_TYPE_VXLAN_GPE: > + ret =3D i40e_add_vxlan_port(pf, udp_tunnel->udp_port, > + I40E_AQC_TUNNEL_TYPE_VXLAN_GPE); > break; > - > case RTE_TUNNEL_TYPE_GENEVE: > case RTE_TUNNEL_TYPE_TEREDO: > PMD_DRV_LOG(ERR, "Tunnel type is not supported now."); @@ > -8490,6 +8494,7 @@ i40e_dev_udp_tunnel_port_del(struct rte_eth_dev *dev, >=20 > switch (udp_tunnel->prot_type) { > case RTE_TUNNEL_TYPE_VXLAN: > + case RTE_TUNNEL_TYPE_VXLAN_GPE: > ret =3D i40e_del_vxlan_port(pf, udp_tunnel->udp_port); > break; > case RTE_TUNNEL_TYPE_GENEVE: > -- > 2.9.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 98698A05FE for ; Mon, 18 Mar 2019 13:25:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B304E2C60; Mon, 18 Mar 2019 13:25:52 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 240D12C54 for ; Mon, 18 Mar 2019 13:25:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Mar 2019 05:25:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,493,1544515200"; d="scan'208";a="308163062" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 18 Mar 2019 05:25:49 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Mar 2019 05:25:49 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Mar 2019 05:25:48 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.113]) with mapi id 14.03.0415.000; Mon, 18 Mar 2019 20:25:47 +0800 From: "Zhang, Qi Z" To: "Yang, Qiming" , "dev@dpdk.org" Thread-Topic: [PATCH v3 2/5] net/i40e: add support for VXLAN-GPE Thread-Index: AQHU3WNKyUKQ3YQfhk6WgWudC+kWjaYRRO4Q Date: Mon, 18 Mar 2019 12:25:47 +0000 Message-ID: <039ED4275CED7440929022BC67E706115334E4C9@SHSMSX103.ccr.corp.intel.com> References: <20190318133230.140978-1-qiming.yang@intel.com> <20190318154200.28409-1-qiming.yang@intel.com> <20190318154200.28409-3-qiming.yang@intel.com> In-Reply-To: <20190318154200.28409-3-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2M0ZDQ3YzItZDdjYS00ZTNmLWE2Y2YtOTQzYWRkYzBkN2ZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVWpEeG13ZE44SmpzS0J1WXgxNVhuc0l3SzJUT0xmTm05aVAwbWxGMGdMalJjNklBRnJ5bllRNStwN3p1MGJJSSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/5] net/i40e: add support for VXLAN-GPE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190318122547.nC5gUppeVfslV_nMc99WTvcls4c40BQSbRGgdadPEzM@z> > -----Original Message----- > From: Yang, Qiming > Sent: Monday, March 18, 2019 11:42 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > Subject: [PATCH v3 2/5] net/i40e: add support for VXLAN-GPE >=20 > Can recognize new packet type VXLAN-GPE in i40e driver. > Added inner IP/TCP/UDP checksum and RSS support for VXLAN-GPE packet. The commit log is a missing leading. . there is no inner IP/TCP/UDP checksum and RSS related change May reword to Add new protocol type VXLAN-GPE support for UDP tunnel. inner IP/TCP/UDP checksum and RSS configuration shared the same implementat= ion of VXLAN. >=20 > Signed-off-by: Qiming Yang > --- > drivers/net/i40e/i40e_ethdev.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index dca61f0..b2ec5cc 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -8368,7 +8368,7 @@ i40e_get_vxlan_port_idx(struct i40e_pf *pf, uint16_= t > port) } >=20 > static int > -i40e_add_vxlan_port(struct i40e_pf *pf, uint16_t port) > +i40e_add_vxlan_port(struct i40e_pf *pf, uint16_t port, int udp_type) > { > int idx, ret; > uint8_t filter_idx; > @@ -8391,7 +8391,7 @@ i40e_add_vxlan_port(struct i40e_pf *pf, uint16_t po= rt) > return -ENOSPC; > } >=20 > - ret =3D i40e_aq_add_udp_tunnel(hw, port, > I40E_AQC_TUNNEL_TYPE_VXLAN, > + ret =3D i40e_aq_add_udp_tunnel(hw, port, udp_type, > &filter_idx, NULL); > if (ret < 0) { > PMD_DRV_LOG(ERR, "Failed to add VXLAN UDP port %d", port); @@ > -8459,9 +8459,13 @@ i40e_dev_udp_tunnel_port_add(struct rte_eth_dev *dev, >=20 > switch (udp_tunnel->prot_type) { > case RTE_TUNNEL_TYPE_VXLAN: > - ret =3D i40e_add_vxlan_port(pf, udp_tunnel->udp_port); > + ret =3D i40e_add_vxlan_port(pf, udp_tunnel->udp_port, > + I40E_AQC_TUNNEL_TYPE_VXLAN); > + break; > + case RTE_TUNNEL_TYPE_VXLAN_GPE: > + ret =3D i40e_add_vxlan_port(pf, udp_tunnel->udp_port, > + I40E_AQC_TUNNEL_TYPE_VXLAN_GPE); > break; > - > case RTE_TUNNEL_TYPE_GENEVE: > case RTE_TUNNEL_TYPE_TEREDO: > PMD_DRV_LOG(ERR, "Tunnel type is not supported now."); @@ > -8490,6 +8494,7 @@ i40e_dev_udp_tunnel_port_del(struct rte_eth_dev *dev, >=20 > switch (udp_tunnel->prot_type) { > case RTE_TUNNEL_TYPE_VXLAN: > + case RTE_TUNNEL_TYPE_VXLAN_GPE: > ret =3D i40e_del_vxlan_port(pf, udp_tunnel->udp_port); > break; > case RTE_TUNNEL_TYPE_GENEVE: > -- > 2.9.5