Re: [dpdk-dev] [PATCH] net/ice: stop lldp by default

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
> Sent: Wednesday, April 3, 2019 11:59 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ice: stop lldp by default
> 
> This patch stopped lldp by default to avoid the statistics error.
> 
> Fixes: f9cf4f864150 ("net/ice: support device initialization")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 1482ced..b3df282 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -11,6 +11,7 @@
> 
>  #include "base/ice_sched.h"
>  #include "base/ice_flow.h"
> +#include "base/ice_dcb.h"
>  #include "ice_ethdev.h"
>  #include "ice_rxtx.h"
> 
> @@ -1406,6 +1407,10 @@ ice_dev_init(struct rte_eth_dev *dev)
>  	/* Disable double vlan by default */
>  	ice_vsi_config_double_vlan(vsi, FALSE);
> 
> +	ret = ice_aq_stop_lldp(hw, TRUE, NULL);
> +	if (ret != ICE_SUCCESS)
> +		PMD_INIT_LOG(DEBUG, "Failed to stop lldp");

I think we need to warning user here if LLDP can't be stopped.

> +
>  	/* register callback func to eal lib */
>  	rte_intr_callback_register(intr_handle,
>  				   ice_interrupt_handler, dev);
> --
> 2.9.5