From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5E5741B46D; Fri, 5 Apr 2019 10:01:37 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 01:01:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,310,1549958400"; d="scan'208";a="137795663" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 05 Apr 2019 01:01:36 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 5 Apr 2019 01:01:36 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 5 Apr 2019 01:01:35 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.153]) with mapi id 14.03.0415.000; Fri, 5 Apr 2019 16:01:34 +0800 From: "Zhang, Qi Z" To: "Yang, Qiming" , "dev@dpdk.org" CC: "Yang, Qiming" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ice: stop lldp by default Thread-Index: AQHU6ffUgbwGq2szqUumpqk6gJUidqYtNjiA Date: Fri, 5 Apr 2019 08:01:34 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153363EAA@SHSMSX103.ccr.corp.intel.com> References: <20190403155921.184963-1-qiming.yang@intel.com> In-Reply-To: <20190403155921.184963-1-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmQ2YTIzY2QtNDdmNS00YTE3LTllYTYtYzg3NzU3MWIxNjAzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMEw1cHY4YVU0RWE0eEJMWEF2ZTQ2bEpLcGxsMlFaaHpYa2F0ME15Tld1QmFHSUMwaWhVRGtjaFc1VFwvSHRYM1IifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: stop lldp by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2019 08:01:38 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang > Sent: Wednesday, April 3, 2019 11:59 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice: stop lldp by default >=20 > This patch stopped lldp by default to avoid the statistics error. >=20 > Fixes: f9cf4f864150 ("net/ice: support device initialization") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qiming Yang > --- > drivers/net/ice/ice_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c = index > 1482ced..b3df282 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -11,6 +11,7 @@ >=20 > #include "base/ice_sched.h" > #include "base/ice_flow.h" > +#include "base/ice_dcb.h" > #include "ice_ethdev.h" > #include "ice_rxtx.h" >=20 > @@ -1406,6 +1407,10 @@ ice_dev_init(struct rte_eth_dev *dev) > /* Disable double vlan by default */ > ice_vsi_config_double_vlan(vsi, FALSE); >=20 > + ret =3D ice_aq_stop_lldp(hw, TRUE, NULL); > + if (ret !=3D ICE_SUCCESS) > + PMD_INIT_LOG(DEBUG, "Failed to stop lldp"); I think we need to warning user here if LLDP can't be stopped. > + > /* register callback func to eal lib */ > rte_intr_callback_register(intr_handle, > ice_interrupt_handler, dev); > -- > 2.9.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 95859A0679 for ; Fri, 5 Apr 2019 10:01:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 31DBA1B474; Fri, 5 Apr 2019 10:01:39 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5E5741B46D; Fri, 5 Apr 2019 10:01:37 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 01:01:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,310,1549958400"; d="scan'208";a="137795663" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 05 Apr 2019 01:01:36 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 5 Apr 2019 01:01:36 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 5 Apr 2019 01:01:35 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.153]) with mapi id 14.03.0415.000; Fri, 5 Apr 2019 16:01:34 +0800 From: "Zhang, Qi Z" To: "Yang, Qiming" , "dev@dpdk.org" CC: "Yang, Qiming" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ice: stop lldp by default Thread-Index: AQHU6ffUgbwGq2szqUumpqk6gJUidqYtNjiA Date: Fri, 5 Apr 2019 08:01:34 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153363EAA@SHSMSX103.ccr.corp.intel.com> References: <20190403155921.184963-1-qiming.yang@intel.com> In-Reply-To: <20190403155921.184963-1-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmQ2YTIzY2QtNDdmNS00YTE3LTllYTYtYzg3NzU3MWIxNjAzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMEw1cHY4YVU0RWE0eEJMWEF2ZTQ2bEpLcGxsMlFaaHpYa2F0ME15Tld1QmFHSUMwaWhVRGtjaFc1VFwvSHRYM1IifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: stop lldp by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190405080134.uTEe1cOewnDkrIkhGndj9mNs6EK9ztKGswiT1-mTw0k@z> > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang > Sent: Wednesday, April 3, 2019 11:59 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice: stop lldp by default >=20 > This patch stopped lldp by default to avoid the statistics error. >=20 > Fixes: f9cf4f864150 ("net/ice: support device initialization") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qiming Yang > --- > drivers/net/ice/ice_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c = index > 1482ced..b3df282 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -11,6 +11,7 @@ >=20 > #include "base/ice_sched.h" > #include "base/ice_flow.h" > +#include "base/ice_dcb.h" > #include "ice_ethdev.h" > #include "ice_rxtx.h" >=20 > @@ -1406,6 +1407,10 @@ ice_dev_init(struct rte_eth_dev *dev) > /* Disable double vlan by default */ > ice_vsi_config_double_vlan(vsi, FALSE); >=20 > + ret =3D ice_aq_stop_lldp(hw, TRUE, NULL); > + if (ret !=3D ICE_SUCCESS) > + PMD_INIT_LOG(DEBUG, "Failed to stop lldp"); I think we need to warning user here if LLDP can't be stopped. > + > /* register callback func to eal lib */ > rte_intr_callback_register(intr_handle, > ice_interrupt_handler, dev); > -- > 2.9.5