From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 881031B1F0; Wed, 10 Apr 2019 17:11:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 08:11:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="222250674" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 10 Apr 2019 08:11:05 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 08:11:04 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 08:11:04 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.149]) with mapi id 14.03.0415.000; Wed, 10 Apr 2019 23:11:02 +0800 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , "Xing, Beilei" CC: "Ananyev, Konstantin" , "dev@dpdk.org" , "Yigit, Ferruh" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling Thread-Index: AQHU5Iv/b0O/G6icj0etGaHTo/Vl3KY0juoAgAEHFcA= Date: Wed, 10 Apr 2019 15:11:02 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153366795@SHSMSX103.ccr.corp.intel.com> References: <20190327110005.1454-1-qi.z.zhang@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC0909407FBE54@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909407FBE54@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTA4NWY3OTAtZDVhNi00NjdiLWFjMWMtNzIxYjRjNDAyOWM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieHFNT1NTM29Vek43RGNYK2RXMFFyaDd2d0VGWlk1NUNXUithTjhUTWp6SmZGZ2lZbDNoS2J6d0tleTNMT0lJaiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 15:11:09 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Wednesday, April 10, 2019 3:29 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Yigit, Ferruh ; Zhang, Qi Z ; > stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling >=20 > Hi Qi, >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > > Sent: Wednesday, March 27, 2019 7:00 PM > > To: Xing, Beilei > > Cc: Ananyev, Konstantin ; dev@dpdk.org; > > Yigit, Ferruh ; Zhang, Qi Z > > ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling > > > > No need to add additional vlan tag size for max packet size, since for > > i40e, the queue's Rx Max Frame Size (rxq->max_pkt_len) already > > includes the vlan header size. > > > > Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup") > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > > Cc: stable@dpdk.org > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/i40e/i40e_rxtx.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > I find the similar case in ' i40evf_rxq_init'. Should it be fixed too? Yes, that be fixed also, will send v2 to cover this. Thanks Qi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5A280A0096 for ; Wed, 10 Apr 2019 17:11:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0DE3D1B207; Wed, 10 Apr 2019 17:11:11 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 881031B1F0; Wed, 10 Apr 2019 17:11:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 08:11:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="222250674" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 10 Apr 2019 08:11:05 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 08:11:04 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 08:11:04 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.149]) with mapi id 14.03.0415.000; Wed, 10 Apr 2019 23:11:02 +0800 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , "Xing, Beilei" CC: "Ananyev, Konstantin" , "dev@dpdk.org" , "Yigit, Ferruh" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling Thread-Index: AQHU5Iv/b0O/G6icj0etGaHTo/Vl3KY0juoAgAEHFcA= Date: Wed, 10 Apr 2019 15:11:02 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153366795@SHSMSX103.ccr.corp.intel.com> References: <20190327110005.1454-1-qi.z.zhang@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC0909407FBE54@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909407FBE54@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTA4NWY3OTAtZDVhNi00NjdiLWFjMWMtNzIxYjRjNDAyOWM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieHFNT1NTM29Vek43RGNYK2RXMFFyaDd2d0VGWlk1NUNXUithTjhUTWp6SmZGZ2lZbDNoS2J6d0tleTNMT0lJaiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410151102.3-FG-QKnddj5-ZllPRrBUINrMrxl1VSeNRNSXxH47Ng@z> > -----Original Message----- > From: Lu, Wenzhuo > Sent: Wednesday, April 10, 2019 3:29 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Yigit, Ferruh ; Zhang, Qi Z ; > stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling >=20 > Hi Qi, >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > > Sent: Wednesday, March 27, 2019 7:00 PM > > To: Xing, Beilei > > Cc: Ananyev, Konstantin ; dev@dpdk.org; > > Yigit, Ferruh ; Zhang, Qi Z > > ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling > > > > No need to add additional vlan tag size for max packet size, since for > > i40e, the queue's Rx Max Frame Size (rxq->max_pkt_len) already > > includes the vlan header size. > > > > Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup") > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > > Cc: stable@dpdk.org > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/i40e/i40e_rxtx.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > I find the similar case in ' i40evf_rxq_init'. Should it be fixed too? Yes, that be fixed also, will send v2 to cover this. Thanks Qi