From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id DD8E5A00E6
for <public@inbox.dpdk.org>; Tue, 11 Jun 2019 03:29:09 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id BC8C91C1EF;
Tue, 11 Jun 2019 03:29:09 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id 607BE1C1ED;
Tue, 11 Jun 2019 03:29:07 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
10 Jun 2019 18:29:06 -0700
X-ExtLoop1: 1
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
by fmsmga007.fm.intel.com with ESMTP; 10 Jun 2019 18:29:06 -0700
Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by
FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Mon, 10 Jun 2019 18:29:06 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Mon, 10 Jun 2019 18:29:06 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.120]) by
SHSMSX101.ccr.corp.intel.com ([169.254.1.10]) with mapi id 14.03.0415.000;
Tue, 11 Jun 2019 09:29:03 +0800
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wang, Liang-min"
<liang-min.wang@intel.com>, "daniels@research.att.com"
<daniels@research.att.com>, "ktraynor@redhat.com" <ktraynor@redhat.com>
CC: "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH v2] net/ixgbevf: add an option pflink_fullchk to get
link status nowait
Thread-Index: AQHVHUotgYH9elN6UkSPNlo+hOPmPKaUvxcwgADud8A=
Date: Tue, 11 Jun 2019 01:29:02 +0000
Message-ID: <039ED4275CED7440929022BC67E706115339A0DD@SHSMSX103.ccr.corp.intel.com>
References: <1559922981-101848-1-git-send-email-haiyue.wang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTdlM2Q1OWUtMjJjNC00MWQ0LThhZDctNTZmMWJlNjdjNDc0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK2JScFM1anlGcm5uRFwvWkhzbzZ3RXppR2M1R2I3RWpRNlwvZnU3RTB1UlNmOWdncm9FWFhSQmgrdVZ4MHVyaFErIn0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbevf: add an option pflink_fullchk
to get link status nowait
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Monday, June 10, 2019 7:17 PM
> To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Wang, Liang-min <liang-min.wang@intel.com>;
> daniels@research.att.com; ktraynor@redhat.com
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v2] net/ixgbevf: add an option pflink_fullchk to get =
link
> status nowait
>=20
>=20
>=20
> > -----Original Message-----
> > From: Wang, Haiyue
> > Sent: Friday, June 7, 2019 11:56 PM
> > To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>; Wang, Liang-min <liang-min.wang@intel.com>;
> > daniels@research.att.com; ktraynor@redhat.com
> > Cc: Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org
> > Subject: [PATCH v2] net/ixgbevf: add an option pflink_fullchk to get
> > link status nowait
> >
> > To get the VF's link status by calling 'rte_eth_link_get_nowait()',
> > the VF not only check PF's physical link status, but also check the mai=
lbox
> running status.
> > And mailbox checking will generate mailbox interrupt in PF, it will be
> > worse if many VFs are running in the system, the PF will have to
> > handle many interrrupts.
interrupts
> >
> > Normally, checking the PF's physical link status is enough for nowait.
> > For different scenarios, adding an 'pflink_fullchk' option to control
> > whether to check the link fully or not.
>=20
> Seems the patch change the default behavior which is always "fully check"=
, I
> assume a no fully check does not guarantee the link status is synced corr=
ectly,
> right?
> should we implement this devargs in an inverse way to avoid the inconsist=
ent
> with previous version?
> From my view correctness should take high priority than performance.
Checked with author, actually below patch change the default behavior on no=
wait case
Fixes: 91546fb62e67 ("net/ixgbevf: fix link state")
The patch roll it back and add devarg option for specific requirement, that=
make sense.
Applied to dpdk-next-net-intel.
Thanks
Qi