From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5323DA0487 for ; Thu, 4 Jul 2019 14:48:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E57881BE27; Thu, 4 Jul 2019 14:48:32 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 92C721BE24 for ; Thu, 4 Jul 2019 14:48:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jul 2019 05:48:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,451,1557212400"; d="scan'208";a="164632815" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 04 Jul 2019 05:48:28 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Jul 2019 05:48:28 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Jul 2019 05:48:28 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.55]) with mapi id 14.03.0439.000; Thu, 4 Jul 2019 20:48:26 +0800 From: "Zhang, Qi Z" To: Adrien Mazarguil , "Su, Simei" CC: "Wu, Jingjing" , "Xing, Beilei" , "Yang, Qiming" , "dev@dpdk.org" , Shahaf Shuler , "Yongseok Koh" Thread-Topic: [dpdk-dev] [RFC] ethdev: support symmetric hash function Thread-Index: AQHVMilYeyEP4r9kkUuREBv/h84eEKa5pTOAgADC5jA= Date: Thu, 4 Jul 2019 12:48:25 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D5FF60@SHSMSX105.ccr.corp.intel.com> References: <1562215567-75436-1-git-send-email-simei.su@intel.com> <20190704090651.GJ4512@6wind.com> In-Reply-To: <20190704090651.GJ4512@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjliMGMxMjAtMWViNS00YWQ5LWEyMTEtOWM5OTIyYzg1ZThiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUFkyQ3pOa2t2dmhYTzcyNmpXRDEzQ1ByOUEyTkVYTFE0YldBSTV4XC8wdGZxdnFJY2JWdmVFTFh5N3ZYTmNiWWEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC] ethdev: support symmetric hash function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Thursday, July 4, 2019 5:07 PM > To: Su, Simei > Cc: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei ; Yang, Qiming ; > dev@dpdk.org; Shahaf Shuler ; Yongseok Koh > > Subject: Re: [dpdk-dev] [RFC] ethdev: support symmetric hash function >=20 > On Thu, Jul 04, 2019 at 12:46:07PM +0800, simei wrote: > > From: Simei Su > > > > Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash funtion. > > To support symmetric hash by rte_flow RSS action, this RFC introduces > > SYMMETRIC_TOEPLITZ to rte_eth_hash_function. > > > > Signed-off-by: Simei Su > > --- > > lib/librte_ethdev/rte_flow.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_ethdev/rte_flow.h > > b/lib/librte_ethdev/rte_flow.h index f3a8fb1..e3c4fe5 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -1744,6 +1744,7 @@ enum rte_eth_hash_function { > > RTE_ETH_HASH_FUNCTION_DEFAULT =3D 0, > > RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */ > > RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */ > > + RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ, /**< Symmetric > TOEPLITZ */ >=20 > "Symmetric TOEPLITZ" =3D> "Symmetric Toeplitz." >=20 > > RTE_ETH_HASH_FUNCTION_MAX, > > }; >=20 > Other than that, no problem with this change (no ABI impact, no need for > deprecation). Please update testpmd a part of the same patch: Is it still ABI break but just with little risk?=20 RTE_ETH_HASH_FUNCTION_MAX's value is changed anyway. Should we just remove it, if no one use it? Regards Qi >=20 > - Wherever "toeplitz" is mentioned in test-pmd/cmdline.c. >=20 > - Ditto for flow command, i.e. add ACTION_RSS_FUNC_SYMMETRIC_TOEPLITZ > to > test-pmd/cmdline_flow.c. >=20 > - Update "set_hash_global_config" documentation section in > testpmd_app_ug/testpmd_funcs.rst. >=20 > Note to Shahaf/Yongseok, since mlx5 supports both but defaults to symmetr= ic > Toeplitz on vanilla Linux and standard Toeplitz when using OFED, how abou= t > using this chance to make the algorithm configurable as well? >=20 > Thanks. >=20 > -- > Adrien Mazarguil > 6WIND