From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40DF2A00E6 for ; Mon, 8 Jul 2019 04:10:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 135474C94; Mon, 8 Jul 2019 04:10:31 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 87548378B; Mon, 8 Jul 2019 04:10:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jul 2019 19:10:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,464,1557212400"; d="scan'208";a="167539250" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 07 Jul 2019 19:10:28 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 7 Jul 2019 19:10:28 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 7 Jul 2019 19:10:27 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 7 Jul 2019 19:10:27 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.60]) with mapi id 14.03.0439.000; Mon, 8 Jul 2019 10:10:25 +0800 From: "Zhang, Qi Z" To: "Wang, Xiao W" CC: "dev@dpdk.org" , "Kiejdo, Marek" , "stable@dpdk.org" Thread-Topic: [PATCH] net/fm10k: fix descriptor filling in vector Tx Thread-Index: AQHVMUz7laXjABE/A06yaUlDEyaZkKbAAeIw Date: Mon, 8 Jul 2019 02:10:25 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D6127C@SHSMSX105.ccr.corp.intel.com> References: <20190703025332.99183-1-xiao.w.wang@intel.com> In-Reply-To: <20190703025332.99183-1-xiao.w.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTY3NGZhMDAtZWIyMS00YjIyLTg0MmMtOGI0YzQxMWYwMzk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQWVUWHJNV0owcHhnU0Q0NzJkMUE3WHpvWVN6akttaHFoZ2ZibHlDZ0NVQ3BrNmw1QUFFT1k3Y2VkZFBkUnZLRiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix descriptor filling in vector Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Xiao W > Sent: Wednesday, July 3, 2019 10:54 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Kiejdo, Marek ; Wang, Xiao W > ; stable@dpdk.org > Subject: [PATCH] net/fm10k: fix descriptor filling in vector Tx >=20 > The shift left operation "pkt->vlan_tci << 16" gets vlan_tci extended to = signed > type and may cause invalid descriptor. Also the same issue for the "data_= len" > field. This patch fixes it by casting them to uint64_t. >=20 > Fixes: 21f13c541eb0 ("fm10k: add vector Tx") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiao Wang Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi