From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2290EA00E6 for ; Mon, 8 Jul 2019 09:27:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 604721C01; Mon, 8 Jul 2019 09:27:31 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B8C3DA3; Mon, 8 Jul 2019 09:27:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jul 2019 00:27:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,465,1557212400"; d="scan'208";a="316638307" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 08 Jul 2019 00:27:28 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 8 Jul 2019 00:27:28 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 8 Jul 2019 00:27:27 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 8 Jul 2019 00:27:27 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.162]) with mapi id 14.03.0439.000; Mon, 8 Jul 2019 15:27:26 +0800 From: "Zhang, Qi Z" To: "Pei, Andy" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Xing, Beilei" , "Yigit, Ferruh" , "Xu, Rosen" , "Ye, Xiaolong" , "Zhang, Roy Fan" , "stable@dpdk.org" Thread-Topic: [PATCH v4] net/i40e: i40e get link status update from ipn3ke Thread-Index: AQHVNTqkbjWQ63rw+U6VCYOZPczy/abAUgAQ Date: Mon, 8 Jul 2019 07:27:26 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D6147F@SHSMSX105.ccr.corp.intel.com> References: <1562223367-292259-1-git-send-email-andy.pei@intel.com> <1562554988-17394-1-git-send-email-andy.pei@intel.com> In-Reply-To: <1562554988-17394-1-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTQ2NjhmZDctOTkzMS00YmMwLWEyMmItNDY2ODc3NzNiODQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSFBuWDNCdUdQNjNZWVIzaHgraW9vU3NOc0pmekUwWWJPdzRyc01CemNheXhHYlFCMzhNbmQ5T1hlTHpqSUFDQyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: i40e get link status update from ipn3ke X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Pei, Andy > Sent: Monday, July 8, 2019 11:03 AM > To: dev@dpdk.org > Cc: Pei, Andy ; Zhang, Qi Z ; W= u, > Jingjing ; Xing, Beilei ; Y= igit, > Ferruh ; Xu, Rosen ; Ye, > Xiaolong ; Zhang, Roy Fan > ; stable@dpdk.org > Subject: [PATCH v4] net/i40e: i40e get link status update from ipn3ke >=20 > Add switch_mode argument for i40e PF to specify the specific FPGA that i4= 0e > PF is connected to. i40e PF get link status update via the connected FPGA= . > Add switch_ethdev to rte_eth_dev_data to track the bind switch device. > Try to bind i40e pf to switch device when i40e device is probed. If it fa= il to find > correct switch device, bind will occur again when update i40e device link > status. >=20 > Signed-off-by: Andy Pei ..... > diff --git a/lib/librte_ethdev/rte_ethdev_core.h > b/lib/librte_ethdev/rte_ethdev_core.h > index 2922d5b..62adc5c 100644 > --- a/lib/librte_ethdev/rte_ethdev_core.h > +++ b/lib/librte_ethdev/rte_ethdev_core.h > @@ -635,6 +635,10 @@ struct rte_eth_dev_data { > /**< Switch-specific identifier. > * Valid if RTE_ETH_DEV_REPRESENTOR in dev_flags. > */ > + struct rte_eth_dev *switch_ethdev; > + /* point to switch_ethdev specific by "switch_mode" in > + * devargs > + */ > } __rte_cache_aligned; Missing below comment in previous review. No need to add new field in rte_eth_dev_data to break ABI, you can just add= to i40e specific structure: i40e_pf. >=20 > /** > -- > 1.8.3.1