From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Ergin, Mesut A" <mesut.a.ergin@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow double mark action error check
Date: Fri, 26 Jul 2019 04:48:15 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153D7413E@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <1564091449-34248-1-git-send-email-mesut.a.ergin@intel.com>
> -----Original Message-----
> From: Ergin, Mesut A
> Sent: Friday, July 26, 2019 5:51 AM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>; Ergin,
> Mesut A <mesut.a.ergin@intel.com>
> Subject: [PATCH] net/i40e: fix flow double mark action error check
>
> This commit fixes an issue with the error checking in flow MARK action.
> Previously, (ANY + MARK) would fail, as the (mark_spec == 0) condition
> would cause an early error return, however really it is (mark_spec != 0) that
> should cause the early error return.
>
> Flipping the binary comparison corrects the behaviour, and (ANY + MARK)
> now succeeds, while (MARK + MARK) fails.
>
> Fixes: 0bbcfc706a2b ("net/i40e: support MARK and RSS flow action")
>
> Suggested-by: Harry van Haaren <harry.van.haaren@intel.com>
> Signed-off-by: Mesut Ali Ergin <mesut.a.ergin@intel.com>
> ---
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2019-07-26 4:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 21:50 Mesut Ali Ergin
2019-07-26 4:48 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153D7413E@SHSMSX105.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=mesut.a.ergin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).