From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DC12A2EFC for ; Tue, 17 Sep 2019 03:53:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FFC01BEC9; Tue, 17 Sep 2019 03:53:20 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C2CF61BEA6 for ; Tue, 17 Sep 2019 03:53:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 18:53:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,514,1559545200"; d="scan'208";a="186013143" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 16 Sep 2019 18:53:16 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Sep 2019 18:53:16 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Sep 2019 18:53:16 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.23]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.32]) with mapi id 14.03.0439.000; Tue, 17 Sep 2019 09:53:14 +0800 From: "Zhang, Qi Z" To: Gavin Hu , "dev@dpdk.org" CC: "nd@arm.com" , "thomas@monjalon.net" , "Richardson, Bruce" , "Liu, Yong" , "Wang, Yinan" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "Honnappa.Nagarahalli@arm.com" , "ruifeng.wang@arm.com" , "steve.capper@arm.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier Thread-Index: AQHVbIHN2lrh+cQw6ES7IuSSZTYA46cvG87w Date: Tue, 17 Sep 2019 01:53:14 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D97A8A@SHSMSX105.ccr.corp.intel.com> References: <1567751873-15964-1-git-send-email-gavin.hu@arm.com> <1568633238-47888-2-git-send-email-gavin.hu@arm.com> In-Reply-To: <1568633238-47888-2-git-send-email-gavin.hu@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTdjNDVjMDgtMmE2OS00ZjFhLTliNTQtOGMzMWZhZWQ4NzFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoianY3U21YMjg3WnhNcVZldGg3ZEc1eWE1T0d5ZkRjVjA3dWNGSU80ZGw4eFV0K2d6eTBRXC9qQzhZZVdrSlM1clwvIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gavin Hu > Sent: Monday, September 16, 2019 7:27 PM > To: dev@dpdk.org > Cc: nd@arm.com; thomas@monjalon.net; Richardson, Bruce > ; Liu, Yong ; Wang, Yinan > ; ajit.khaparde@broadcom.com; > somnath.kotur@broadcom.com; Honnappa.Nagarahalli@arm.com; > ruifeng.wang@arm.com; steve.capper@arm.com > Subject: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove > duplicate barrier >=20 > To guarantee the orderings of successive stores to CIO and MMIO memory, a > lighter weight rte_io_wmb [1] can be used instead of rte_wmb, and since t= he > I40E_PCI_REG_WRITE API already has an inclusive rte_io_wmb, this explicit= call > can be even saved. >=20 > [1] http://git.dpdk.org/dpdk/tree/lib/librte_eal/common/include/generic/ > rte_atomic.h#n98 >=20 > Signed-off-by: Gavin Hu Can you also capture the one at the tail of i40e_xmit_pkts? Otherwise Acked-by: Qi Zhang