From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E5ECA2EFC for ; Tue, 17 Sep 2019 07:13:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 039EC1BFB2; Tue, 17 Sep 2019 07:13:58 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C13721BFB1 for ; Tue, 17 Sep 2019 07:13:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 22:13:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,515,1559545200"; d="scan'208";a="216448760" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 16 Sep 2019 22:13:54 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Sep 2019 22:13:54 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.23]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.32]) with mapi id 14.03.0439.000; Tue, 17 Sep 2019 13:13:52 +0800 From: "Zhang, Qi Z" To: "Gavin Hu (Arm Technology China)" , "dev@dpdk.org" CC: nd , "thomas@monjalon.net" , "Richardson, Bruce" , "Liu, Yong" , "Wang, Yinan" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "Honnappa Nagarahalli" , "Ruifeng Wang (Arm Technology China)" , Steve Capper Thread-Topic: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier Thread-Index: AQHVbQdeloCo5P+R6Ee6dCR02fK3F6cvUdVQ Date: Tue, 17 Sep 2019 05:13:52 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D97B6E@SHSMSX105.ccr.corp.intel.com> References: <1567751873-15964-1-git-send-email-gavin.hu@arm.com> <1568633238-47888-2-git-send-email-gavin.hu@arm.com> <039ED4275CED7440929022BC67E7061153D97A8A@SHSMSX105.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzY4YzFlNTYtYTllMy00MmVjLTlkZGUtZWJlMjEwOGZhZDMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTjYrU0dzQjhJSXBtanMwS0ZHNEl1akxZc203cGZhcUVvRXMzTnBHM3NYbTdTSG11T0dTVlpcLzlyQnZOazNCVFgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu@arm.com] > Sent: Tuesday, September 17, 2019 11:24 AM > To: Gavin Hu (Arm Technology China) ; Zhang, Qi Z > ; dev@dpdk.org > Cc: nd ; thomas@monjalon.net; Richardson, Bruce > ; Liu, Yong ; Wang, Yinan > ; ajit.khaparde@broadcom.com; > somnath.kotur@broadcom.com; Honnappa Nagarahalli > ; Ruifeng Wang (Arm Technology China) > ; Steve Capper > Subject: RE: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove > duplicate barrier >=20 > Hi Qi, >=20 > > -----Original Message----- > > From: dev On Behalf Of Gavin Hu (Arm Technology > > China) > > Sent: Tuesday, September 17, 2019 10:08 AM > > To: Zhang, Qi Z ; dev@dpdk.org > > Cc: nd ; thomas@monjalon.net; Richardson, Bruce > > ; Liu, Yong ; Wang, > > Yinan ; ajit.khaparde@broadcom.com; > > somnath.kotur@broadcom.com; Honnappa Nagarahalli > > ; Ruifeng Wang (Arm Technology China) > > ; Steve Capper > > Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and > > remove duplicate barrier > > > > Hi Qi, > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Tuesday, September 17, 2019 9:53 AM > > > To: Gavin Hu (Arm Technology China) ; > > dev@dpdk.org > > > Cc: nd ; thomas@monjalon.net; Richardson, Bruce > > > ; Liu, Yong ; Wang, > > Yinan > > > ; ajit.khaparde@broadcom.com; > > > somnath.kotur@broadcom.com; Honnappa Nagarahalli > > > ; Ruifeng Wang (Arm Technology > > China) > > > ; Steve Capper > > > Subject: RE: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and > > > remove duplicate barrier > > > > > > > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gavin Hu > > > > Sent: Monday, September 16, 2019 7:27 PM > > > > To: dev@dpdk.org > > > > Cc: nd@arm.com; thomas@monjalon.net; Richardson, Bruce > > > > ; Liu, Yong ; > > > > Wang, > > > Yinan > > > > ; ajit.khaparde@broadcom.com; > > > > somnath.kotur@broadcom.com; Honnappa.Nagarahalli@arm.com; > > > > ruifeng.wang@arm.com; steve.capper@arm.com > > > > Subject: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and > > > > remove duplicate barrier > > > > > > > > To guarantee the orderings of successive stores to CIO and MMIO > > memory, > > > a > > > > lighter weight rte_io_wmb [1] can be used instead of rte_wmb, and > > since > > > the > > > > I40E_PCI_REG_WRITE API already has an inclusive rte_io_wmb, this > > explicit > > > call > > > > can be even saved. > > > > > > > > [1] > > http://git.dpdk.org/dpdk/tree/lib/librte_eal/common/include/generic/ > > > > rte_atomic.h#n98 > > > > > > > > Signed-off-by: Gavin Hu > > > > > > Can you also capture the one at the tail of i40e_xmit_pkts? > > Thanks for your review, I will fix this in next version. > I checked again, in this version, the rte_wmb at the tail of i40e_xmit_pk= ts was > already removed and the following I40E_PCI_REG_WRITE_RELAXED was > replaced by I40E_PCI_REG_WRITE, which has an inclusive rte_io_wmb. Sorry, I must mixed the with ice patch, yes you are right, its already ther= e. > > > > > > Otherwise > > > Acked-by: Qi Zhang > > >