From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
"Su, Simei" <simei.su@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: extend RSS offload types
Date: Fri, 27 Sep 2019 05:54:55 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153D9ED99@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <a2a6a432-5cf4-fbf4-7b0e-440128af5e54@solarflare.com>
From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
Sent: Thursday, September 26, 2019 5:16 PM
To: Su, Simei <simei.su@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: extend RSS offload types
On 9/25/19 5:06 PM, Simei Su wrote:
This patch cover two aspects:
(1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve
different purposes.
(2)reserve several bits as input set selection from the high
end of the 64 bits. It is combined with exisiting ETH_RSS_*
to represent rss types.
If the patch covers two aspects why it is one patch instead of two?
It would be useful to motivate decouple a bit getter and provide
details since "different purposes" are hardly very useful. Which
purposes?
[Qi: ]Though the second purpose depends on the first one, but I agree, it’s better to separate them in two patches
for example:
ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY: hash on src ip address only
Is (ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY)
valid and an equivalent to ETH_RSS_IPV4 only?
[Qi:] The word “only” should be an exclusive attribute , so I don’t think ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY is a valid case,
Such configure should be rejected by all PMD ( better be handled in generic API, but I did see a good place to add so far)
But I guess that should not be a problem, since nobody will intend to use with that way, also exist PMD may reject any new bit it don't know.
If yes, shouldn't generic API care about it or each driver should do it?
Similar question is applicable to L4.
ETH_RSS_IPV4_UDP | ETH_RSS_L4_DST_ONLY: hash on src/dst IP and
dst UDP port
ETH_RSS_L2_PAYLOAD | ETH_RSS_L2_DST_ONLY: hash on dst mac address
I'm a bit confused by L2_PAYLOAD | L2_DST_ONLY. Does L2_PAYLOAD
mean entire L2 frame including header and payload?
[Qi:] yes, seems we are missing L2_RSS_ETH.
Regards
Qi
Signed-off-by: Simei Su <simei.su@intel.com>
[snip]
next prev parent reply other threads:[~2019-09-27 5:55 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 5:35 [dpdk-dev] [PATCH 0/2] " simei
2019-08-09 5:35 ` [dpdk-dev] [PATCH 1/2] ethdev: " simei
2019-08-09 5:35 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add RSS offload types extending support simei
2019-09-23 14:05 ` [dpdk-dev] [PATCH v2 0/2] extend RSS offload types Simei Su
2019-09-23 14:05 ` [dpdk-dev] [PATCH v2 1/2] ethdev: " Simei Su
2019-09-25 10:27 ` Ye Xiaolong
2019-09-25 12:04 ` Su, Simei
2019-09-25 12:23 ` Ye Xiaolong
2019-09-25 12:42 ` Su, Simei
2019-09-25 10:49 ` Ye Xiaolong
2019-09-25 12:00 ` Su, Simei
2019-09-25 12:22 ` Ye Xiaolong
2019-09-25 12:38 ` Su, Simei
2019-09-23 14:05 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add RSS offload types extending support Simei Su
2019-09-24 5:32 ` [dpdk-dev] [PATCH v2 0/2] extend RSS offload types Zhang, Qi Z
2019-09-25 14:06 ` [dpdk-dev] [PATCH v3 " Simei Su
2019-09-25 14:06 ` [dpdk-dev] [PATCH v3 1/2] ethdev: " Simei Su
2019-09-26 9:16 ` Andrew Rybchenko
2019-09-27 5:54 ` Zhang, Qi Z [this message]
2019-09-25 14:06 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add RSS offload types extending support Simei Su
2019-09-27 8:54 ` [dpdk-dev] [PATCH v4 0/3] extend RSS offload types Simei Su
2019-09-27 8:54 ` [dpdk-dev] [PATCH v4 1/3] ethdev: decouple flow types and " Simei Su
2019-09-29 11:32 ` Andrew Rybchenko
2019-09-27 8:54 ` [dpdk-dev] [PATCH v4 2/3] ethdev: extend " Simei Su
2019-09-28 1:03 ` Zhang, Qi Z
2019-09-28 1:39 ` Su, Simei
2019-09-27 8:54 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-09-28 16:49 ` Ori Kam
2019-09-29 6:46 ` Su, Simei
2019-09-29 7:21 ` Su, Simei
2019-09-28 2:29 ` [dpdk-dev] [PATCH v5 0/3] extend RSS offload types Simei Su
2019-09-28 2:29 ` [dpdk-dev] [PATCH v5 1/3] ethdev: decouple flow types and " Simei Su
2019-09-28 16:23 ` Ori Kam
2019-09-28 2:29 ` [dpdk-dev] [PATCH v5 2/3] ethdev: extend " Simei Su
2019-09-28 16:26 ` Ori Kam
2019-09-28 2:29 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-09-29 5:11 ` [dpdk-dev] [PATCH v6 0/3] extend RSS offload types Simei Su
2019-09-29 5:11 ` [dpdk-dev] [PATCH v6 1/3] ethdev: decouple flow types and " Simei Su
2019-09-29 5:11 ` [dpdk-dev] [PATCH v6 2/3] ethdev: extend " Simei Su
2019-09-29 11:40 ` Andrew Rybchenko
2019-09-30 7:49 ` Zhang, Qi Z
2019-09-29 5:11 ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-09-29 7:09 ` [dpdk-dev] [PATCH v7 0/3] extend RSS offload types Simei Su
2019-09-29 7:09 ` [dpdk-dev] [PATCH v7 1/3] ethdev: decouple flow types and " Simei Su
2019-09-29 7:55 ` Yang, Zhiyong
2019-09-29 8:38 ` Su, Simei
2019-09-29 7:09 ` [dpdk-dev] [PATCH v7 2/3] ethdev: extend " Simei Su
2019-09-29 8:55 ` Su, Simei
2019-09-29 9:15 ` Su, Simei
2019-09-29 7:09 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-01 14:36 ` [dpdk-dev] [PATCH v8 0/3] extend RSS offload types Simei Su
2019-10-01 14:36 ` [dpdk-dev] [PATCH v8 1/3] ethdev: decouple flow types and " Simei Su
2019-10-01 14:36 ` [dpdk-dev] [PATCH v8 2/3] ethdev: extend " Simei Su
2019-10-01 14:49 ` Andrew Rybchenko
2019-10-01 16:02 ` Iremonger, Bernard
2019-10-01 16:45 ` Ferruh Yigit
2019-10-05 4:54 ` Su, Simei
2019-10-01 14:36 ` [dpdk-dev] [PATCH v8 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-03 11:35 ` [dpdk-dev] [PATCH v9 0/3] extend RSS offload types Simei Su
2019-10-03 11:35 ` [dpdk-dev] [PATCH v9 1/3] ethdev: decouple flow types and " Simei Su
2019-10-03 11:35 ` [dpdk-dev] [PATCH v9 2/3] ethdev: extend " Simei Su
2019-10-03 11:35 ` [dpdk-dev] [PATCH v9 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-04 4:45 ` [dpdk-dev] [PATCH v10 0/3] extend RSS offload types Simei Su
2019-10-04 4:46 ` [dpdk-dev] [PATCH v10 1/3] ethdev: decouple flow types and " Simei Su
2019-10-04 4:46 ` [dpdk-dev] [PATCH v10 2/3] ethdev: extend " Simei Su
2019-10-08 16:45 ` Andrew Rybchenko
2019-10-09 7:06 ` Su, Simei
2019-10-04 4:46 ` [dpdk-dev] [PATCH v10 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-09 6:57 ` [dpdk-dev] [PATCH v11 0/3] extend RSS offload types Simei Su
2019-10-09 6:57 ` [dpdk-dev] [PATCH v11 1/3] ethdev: decouple flow types and " Simei Su
2019-10-09 6:57 ` [dpdk-dev] [PATCH v11 2/3] ethdev: extend " Simei Su
2019-10-09 7:18 ` Andrew Rybchenko
2019-10-09 7:42 ` Su, Simei
2019-10-09 7:55 ` Andrew Rybchenko
2019-10-09 9:08 ` Su, Simei
2019-10-09 9:32 ` Zhang, Qi Z
2019-10-10 14:37 ` Su, Simei
2019-10-09 6:57 ` [dpdk-dev] [PATCH v11 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-14 13:36 ` [dpdk-dev] [PATCH v12 0/3] extend RSS offload types Simei Su
2019-10-14 13:36 ` [dpdk-dev] [PATCH v12 1/3] ethdev: decouple flow types and " Simei Su
2019-10-14 13:36 ` [dpdk-dev] [PATCH v12 2/3] ethdev: extend " Simei Su
2019-10-15 9:07 ` Andrew Rybchenko
2019-10-15 10:55 ` Su, Simei
2019-10-15 11:09 ` Andrew Rybchenko
2019-10-15 11:21 ` Su, Simei
2019-10-14 13:36 ` [dpdk-dev] [PATCH v12 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-15 12:56 ` [dpdk-dev] [PATCH v13 0/3] extend RSS offload types Simei Su
2019-10-15 12:56 ` [dpdk-dev] [PATCH v13 1/3] ethdev: decouple flow types and " Simei Su
2019-10-15 12:56 ` [dpdk-dev] [PATCH v13 2/3] ethdev: extend " Simei Su
2019-10-15 13:07 ` Andrew Rybchenko
2019-10-15 15:00 ` Su, Simei
2019-10-15 12:56 ` [dpdk-dev] [PATCH v13 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-15 15:09 ` [dpdk-dev] [PATCH v14 0/3] extend RSS offload types Simei Su
2019-10-15 15:09 ` [dpdk-dev] [PATCH v14 1/3] ethdev: decouple flow types and " Simei Su
2019-10-15 15:09 ` [dpdk-dev] [PATCH v14 2/3] ethdev: extend " Simei Su
2019-10-15 15:09 ` [dpdk-dev] [PATCH v14 3/3] app/testpmd: add RSS offload types extending support Simei Su
2019-10-18 11:43 ` [dpdk-dev] [PATCH v14 0/3] extend RSS offload types Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153D9ED99@SHSMSX105.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=simei.su@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).