From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83B43A0352; Sat, 9 Nov 2019 04:01:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2CF701C1B9; Sat, 9 Nov 2019 04:01:15 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 098301C196; Sat, 9 Nov 2019 04:01:12 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2019 19:01:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,283,1569308400"; d="scan'208";a="234625945" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 08 Nov 2019 19:01:11 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 Nov 2019 19:01:11 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 Nov 2019 19:01:11 -0800 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.225]) by shsmsx102.ccr.corp.intel.com ([169.254.2.108]) with mapi id 14.03.0439.000; Sat, 9 Nov 2019 11:01:09 +0800 From: "Zhang, Qi Z" To: Thomas Monjalon , Kevin Traynor CC: "Zhang, Xiao" , "dev@dpdk.org" , "Xing, Beilei" , "Stokes, Ian" , "stable@dpdk.org" , Andrew Rybchenko , "Yigit, Ferruh" , "Ye, Xiaolong" Thread-Topic: [v3] net/i40e: fix vlan packets drop Thread-Index: AQHVgmTPJNJ4fEkqukyAxwXnzK4svqdwo/0AgBCmmICAAAW7AIAA/RGA Date: Sat, 9 Nov 2019 03:01:09 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153DC6C1E@SHSMSX105.ccr.corp.intel.com> References: <1571039632-5524-1-git-send-email-xiao.zhang@intel.com> <1572325942-72488-1-git-send-email-xiao.zhang@intel.com> <39c0da13-5bd4-8dd2-ac09-a6ef5c1e3380@redhat.com> <3103941.IzeQdVNKZZ@xps> In-Reply-To: <3103941.IzeQdVNKZZ@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzM5YzhkNGYtNzZmMy00NjZjLTg5MjQtZWI4YWQ0ZmU5MTMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSDBVeUtqbkJZcE16M3RNTk5QdTMzeWN3RnhzMm1VaCtlRjhpTDFCQkZ4XC9WNFhMbzU2OU1oaUtNM0FyTmZkUkkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [v3] net/i40e: fix vlan packets drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Saturday, November 9, 2019 3:49 AM > To: Kevin Traynor > Cc: Zhang, Xiao ; dev@dpdk.org; Xing, Beilei > ; Zhang, Qi Z ; Stokes, Ian > ; stable@dpdk.org; Andrew Rybchenko > ; Yigit, Ferruh ; Ye, > Xiaolong > Subject: Re: [v3] net/i40e: fix vlan packets drop >=20 > 08/11/2019 20:28, Kevin Traynor: > > Hi Xiao, > > > > On 29/10/2019 05:12, Xiao Zhang wrote: > > > VLAN packets with ip length bigger than 1496 will not be received by > > > i40e/i40evf due to wrong packets size checking. This patch fixes the > > > issue by correcting the maximum frame size during checking. > > > > > > Fixes: 43e5488c0ac6 ("net/i40e: support MTU configuration") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Xiao Zhang > > > --- > > > v3 > > > Checking more places using max packet len. > > > v2 > > > Add fix for i40evf and correct the checking when using the max_pkt_le= n. > > > --- > > > drivers/net/i40e/i40e_ethdev.c | 2 +- > > > drivers/net/i40e/i40e_ethdev_vf.c | 11 +++++++---- > > > drivers/net/i40e/i40e_fdir.c | 2 +- > > > drivers/net/i40e/i40e_rxtx.c | 9 ++++++--- > > > lib/librte_ethdev/rte_ethdev.c | 10 ++++++++-- > > > lib/librte_net/rte_ether.h | 1 + > > > 6 files changed, 24 insertions(+), 11 deletions(-) > > > > > > --- a/lib/librte_ethdev/rte_ethdev.c > > > +++ b/lib/librte_ethdev/rte_ethdev.c > > > @@ -1257,11 +1257,17 @@ rte_eth_dev_configure(uint16_t port_id, > uint16_t nb_rx_q, uint16_t nb_tx_q, > > > goto rollback; > > > } > > > } else { > > > + /** > > > + * The overhead from MTU to max frame size. > > > + * Considering VLAN and QinQ packet, the VLAN tag size > > > + * needs to be added to RTE_ETHER_MAX_LEN. > > > + */ > > > if (dev_conf->rxmode.max_rx_pkt_len < RTE_ETHER_MIN_LEN > || > > > - dev_conf->rxmode.max_rx_pkt_len > RTE_ETHER_MAX_LEN) > > > + dev_conf->rxmode.max_rx_pkt_len > RTE_ETHER_MAX_LEN > > > + + RTE_ETHER_VLAN_LEN * 2) > > > /* Use default value */ > > > dev->data->dev_conf.rxmode.max_rx_pkt_len =3D > > > - RTE_ETHER_MAX_LEN; > > > + RTE_ETHER_MAX_LEN + RTE_ETHER_VLAN_LEN * 2; > > > > +cc ethdev maintainers > > > > This looks ok to me for i40e case, but I don't know if there is a > > consequence for other PMDs. It seems late to change this, so maybe you > > can live without this part for now. > > > > Even on the i40e parts, there can be some subtle bug and I requested > > i40e maintainers to review carefully but it has not happened, so for > > me it shouldn't be merged at present. >=20 > I would nack for another, simpler, reason: > No ethdev behaviour change should be submitted if title does not start wi= th > "ethdev:" and if ethdev maintainers are not Cc'ed. >=20 >=20 Yes, the patch should be dropped even without the ethdev part change, the f= ix for i40e need more refine.=20 Sorry for review this late.