From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "Ye, Xiaolong" <xiaolong.ye@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Shelton, Benjamin H" <benjamin.h.shelton@intel.com>,
"Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>
Subject: Re: [dpdk-dev] [PATCH 04/28] net/ice/base: read PSM clock frequency from register
Date: Fri, 20 Mar 2020 07:14:28 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611547E54BD@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <cfc4efc7-0acc-c3d2-cbcf-073a48baeb5d@redhat.com>
Hi Kevin:
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Monday, March 9, 2020 11:45 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: Ye, Xiaolong <xiaolong.ye@intel.com>; dev@dpdk.org; Shelton, Benjamin H
> <benjamin.h.shelton@intel.com>; Stillwell Jr, Paul M
> <paul.m.stillwell.jr@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 04/28] net/ice/base: read PSM clock frequency
> from register
>
> On 09/03/2020 11:43, Qi Zhang wrote:
> > Read the GLGEN_CLKSTAT_SRC register to determine which PSM clock
> > frequency is selected. This ensures that the rate limiter profile
> > calculations will be correct.
> >
>
> This seems to be a fix whereby a default and possibly incorrect frequency was
> used previously. In that case, it should have a Fixes tag (and probably stable tag
> too)
OK, will add fixline
>
> > Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
> > Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> > drivers/net/ice/base/ice_common.c | 1 +
> > drivers/net/ice/base/ice_sched.c | 59
> > +++++++++++++++++++++++++++++++++------
> > drivers/net/ice/base/ice_sched.h | 7 ++++-
> > drivers/net/ice/base/ice_type.h | 4 ++-
> > 4 files changed, 61 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/net/ice/base/ice_common.c
> > b/drivers/net/ice/base/ice_common.c
> > index 786e99d21..9ef1aeef2 100644
> > --- a/drivers/net/ice/base/ice_common.c
> > +++ b/drivers/net/ice/base/ice_common.c
> > @@ -672,6 +672,7 @@ enum ice_status ice_init_hw(struct ice_hw *hw)
> > "Failed to get scheduler allocated resources\n");
> > goto err_unroll_alloc;
> > }
> > + ice_sched_get_psm_clk_freq(hw);
> >
> > /* Initialize port_info struct with scheduler data */
> > status = ice_sched_init_port(hw->port_info);
> > diff --git a/drivers/net/ice/base/ice_sched.c
> > b/drivers/net/ice/base/ice_sched.c
> > index 553fc28ff..26c4ba36f 100644
> > --- a/drivers/net/ice/base/ice_sched.c
> > +++ b/drivers/net/ice/base/ice_sched.c
> > @@ -1369,6 +1369,46 @@ enum ice_status
> > ice_sched_query_res_alloc(struct ice_hw *hw) }
> >
> > /**
> > + * ice_sched_get_psm_clk_freq - determine the PSM clock frequency
> > + * @hw: pointer to the HW struct
> > + *
> > + * Determine the PSM clock frequency and store in HW struct */ void
> > +ice_sched_get_psm_clk_freq(struct ice_hw *hw) {
> > + u32 val, clk_src;
> > +
> > + val = rd32(hw, GLGEN_CLKSTAT_SRC);
> > + clk_src = (val & GLGEN_CLKSTAT_SRC_PSM_CLK_SRC_M) >>
> > + GLGEN_CLKSTAT_SRC_PSM_CLK_SRC_S;
> > +
> > +#define PSM_CLK_SRC_367_MHZ 0x0
> > +#define PSM_CLK_SRC_416_MHZ 0x1
> > +#define PSM_CLK_SRC_446_MHZ 0x2
> > +#define PSM_CLK_SRC_390_MHZ 0x3
> > +
> > + switch (clk_src) {
> > + case PSM_CLK_SRC_367_MHZ:
> > + hw->psm_clk_freq = ICE_PSM_CLK_367MHZ_IN_HZ;
> > + break;
> > + case PSM_CLK_SRC_416_MHZ:
> > + hw->psm_clk_freq = ICE_PSM_CLK_416MHZ_IN_HZ;
> > + break;
> > + case PSM_CLK_SRC_446_MHZ:
> > + hw->psm_clk_freq = ICE_PSM_CLK_446MHZ_IN_HZ;
> > + break;
> > + case PSM_CLK_SRC_390_MHZ:
> > + hw->psm_clk_freq = ICE_PSM_CLK_390MHZ_IN_HZ;
> > + break;
> > + default:
> > + ice_debug(hw, ICE_DBG_SCHED, "PSM clk_src unexpected %u\n",
> > + clk_src);
> > + /* fall back to a safe default */
> > + hw->psm_clk_freq = ICE_PSM_CLK_446MHZ_IN_HZ;
> > + }
> > +}
> > +
> > +/**
> > * ice_sched_find_node_in_subtree - Find node in part of base node
> subtree
> > * @hw: pointer to the HW struct
> > * @base: pointer to the base node
> > @@ -2867,7 +2907,7 @@ ice_sched_update_elem(struct ice_hw *hw, struct
> ice_sched_node *node,
> > */
> > static enum ice_status
> > ice_sched_cfg_node_bw_alloc(struct ice_hw *hw, struct ice_sched_node
> *node,
> > - enum ice_rl_type rl_type, u8 bw_alloc)
> > + enum ice_rl_type rl_type, u16 bw_alloc)
>
> This fix looks unrelated to the commit message
Yes, will move this fix to patch that cover all the minor fix.
>
> > {
> > struct ice_aqc_txsched_elem_data buf;
> > struct ice_aqc_txsched_elem *data;
> > @@ -3671,11 +3711,12 @@ ice_cfg_agg_bw_alloc(struct ice_port_info *pi,
> > u32 agg_id, u8 ena_tcmap,
> >
> > /**
> > * ice_sched_calc_wakeup - calculate RL profile wakeup parameter
> > + * @hw: pointer to the HW struct
> > * @bw: bandwidth in Kbps
> > *
> > * This function calculates the wakeup parameter of RL profile.
> > */
> > -static u16 ice_sched_calc_wakeup(s32 bw)
> > +static u16 ice_sched_calc_wakeup(struct ice_hw *hw, s32 bw)
> > {
> > s64 bytes_per_sec, wakeup_int, wakeup_a, wakeup_b, wakeup_f;
> > s32 wakeup_f_int;
> > @@ -3683,7 +3724,7 @@ static u16 ice_sched_calc_wakeup(s32 bw)
> >
> > /* Get the wakeup integer value */
> > bytes_per_sec = DIV_64BIT(((s64)bw * 1000), BITS_PER_BYTE);
> > - wakeup_int = DIV_64BIT(ICE_RL_PROF_FREQUENCY, bytes_per_sec);
> > + wakeup_int = DIV_64BIT(hw->psm_clk_freq, bytes_per_sec);
> > if (wakeup_int > 63) {
> > wakeup = (u16)((1 << 15) | wakeup_int);
> > } else {
> > @@ -3692,7 +3733,7 @@ static u16 ice_sched_calc_wakeup(s32 bw)
> > */
> > wakeup_b = (s64)ICE_RL_PROF_MULTIPLIER * wakeup_int;
> > wakeup_a = DIV_64BIT((s64)ICE_RL_PROF_MULTIPLIER *
> > - ICE_RL_PROF_FREQUENCY, bytes_per_sec);
> > + hw->psm_clk_freq, bytes_per_sec);
> >
> > /* Get Fraction value */
> > wakeup_f = wakeup_a - wakeup_b;
> > @@ -3712,13 +3753,15 @@ static u16 ice_sched_calc_wakeup(s32 bw)
> >
> > /**
> > * ice_sched_bw_to_rl_profile - convert BW to profile parameters
> > + * @hw: pointer to the HW struct
> > * @bw: bandwidth in Kbps
> > * @profile: profile parameters to return
> > *
> > * This function converts the BW to profile structure format.
> > */
> > static enum ice_status
> > -ice_sched_bw_to_rl_profile(u32 bw, struct ice_aqc_rl_profile_elem
> > *profile)
> > +ice_sched_bw_to_rl_profile(struct ice_hw *hw, u32 bw,
> > + struct ice_aqc_rl_profile_elem *profile)
> > {
> > enum ice_status status = ICE_ERR_PARAM;
> > s64 bytes_per_sec, ts_rate, mv_tmp;
> > @@ -3738,7 +3781,7 @@ ice_sched_bw_to_rl_profile(u32 bw, struct
> ice_aqc_rl_profile_elem *profile)
> > for (i = 0; i < 64; i++) {
> > u64 pow_result = BIT_ULL(i);
> >
> > - ts_rate = DIV_64BIT((s64)ICE_RL_PROF_FREQUENCY,
> > + ts_rate = DIV_64BIT((s64)hw->psm_clk_freq,
> > pow_result * ICE_RL_PROF_TS_MULTIPLIER);
> > if (ts_rate <= 0)
> > continue;
> > @@ -3762,7 +3805,7 @@ ice_sched_bw_to_rl_profile(u32 bw, struct
> ice_aqc_rl_profile_elem *profile)
> > if (found) {
> > u16 wm;
> >
> > - wm = ice_sched_calc_wakeup(bw);
> > + wm = ice_sched_calc_wakeup(hw, bw);
> > profile->rl_multiply = CPU_TO_LE16(mv);
> > profile->wake_up_calc = CPU_TO_LE16(wm);
> > profile->rl_encode = CPU_TO_LE16(encode); @@ -3831,7 +3874,7
> @@
> > ice_sched_add_rl_profile(struct ice_port_info *pi,
> > if (!rl_prof_elem)
> > return NULL;
> >
> > - status = ice_sched_bw_to_rl_profile(bw, &rl_prof_elem->profile);
> > + status = ice_sched_bw_to_rl_profile(hw, bw, &rl_prof_elem->profile);
> > if (status != ICE_SUCCESS)
> > goto exit_add_rl_prof;
> >
> > diff --git a/drivers/net/ice/base/ice_sched.h
> > b/drivers/net/ice/base/ice_sched.h
> > index d6b467477..1a8549931 100644
> > --- a/drivers/net/ice/base/ice_sched.h
> > +++ b/drivers/net/ice/base/ice_sched.h
> > @@ -25,12 +25,16 @@
> > ((BIT(11) - 1) * 64) /* In Bytes */
> > #define ICE_MAX_BURST_SIZE_KBYTE_GRANULARITY
> ICE_MAX_BURST_SIZE_ALLOWED
> >
> > -#define ICE_RL_PROF_FREQUENCY 446000000 #define
> > ICE_RL_PROF_ACCURACY_BYTES 128 #define ICE_RL_PROF_MULTIPLIER
> 10000
> > #define ICE_RL_PROF_TS_MULTIPLIER 32 #define ICE_RL_PROF_FRACTION
> 512
> >
> > +#define ICE_PSM_CLK_367MHZ_IN_HZ 367647059 #define
> > +ICE_PSM_CLK_416MHZ_IN_HZ 416666667 #define
> ICE_PSM_CLK_446MHZ_IN_HZ
> > +446428571 #define ICE_PSM_CLK_390MHZ_IN_HZ 390625000
> > +
> > struct rl_profile_params {
> > u32 bw; /* in Kbps */
> > u16 rl_multiplier;
> > @@ -83,6 +87,7 @@ ice_aq_query_sched_elems(struct ice_hw *hw, u16
> elems_req,
> > u16 *elems_ret, struct ice_sq_cd *cd); enum ice_status
> > ice_sched_init_port(struct ice_port_info *pi); enum ice_status
> > ice_sched_query_res_alloc(struct ice_hw *hw);
> > +void ice_sched_get_psm_clk_freq(struct ice_hw *hw);
> >
> > /* Functions to cleanup scheduler SW DB */ void
> > ice_sched_clear_port(struct ice_port_info *pi); diff --git
> > a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h
> > index 9773a549f..237220ee8 100644
> > --- a/drivers/net/ice/base/ice_type.h
> > +++ b/drivers/net/ice/base/ice_type.h
> > @@ -524,7 +524,7 @@ struct ice_sched_node {
> > #define ICE_TXSCHED_GET_EIR_BWALLOC(x) \
> > LE16_TO_CPU((x)->info.eir_bw.bw_alloc)
> >
> > -struct ice_sched_rl_profle {
> > +struct ice_sched_rl_profile {
>
> Is this used somewhere?
The base code is shared by linux/dpdk/windows, the consideration here is
1) we try to make code identical, otherwise a lot of compile option is involved to strip out code for different usage.
2) some code may not be used on specific platform currently, but might be active in future.
Thanks
Qi
>
> > u32 rate; /* In Kbps */
> > struct ice_aqc_rl_profile_elem info; }; @@ -741,6 +741,8 @@ struct
> > ice_hw {
> > struct ice_sched_rl_profile **cir_profiles;
> > struct ice_sched_rl_profile **eir_profiles;
> > struct ice_sched_rl_profile **srl_profiles;
> > + /* PSM clock frequency for calculating RL profile params */
> > + u32 psm_clk_freq;
> > u64 debug_mask; /* BITMAP for debug mask */
> > enum ice_mac_type mac_type;
> >
> >
next prev parent reply other threads:[~2020-03-20 7:14 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 11:43 [dpdk-dev] [PATCH 00/28] update ice base code Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 01/28] net/ice/base: fix uninitialized stack variables Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 02/28] net/ice/base: add and update E822 device IDs Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 03/28] net/ice/base: fix removing MAC rule Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 04/28] net/ice/base: read PSM clock frequency from register Qi Zhang
2020-03-09 15:45 ` Kevin Traynor
2020-03-20 7:14 ` Zhang, Qi Z [this message]
2020-03-20 10:44 ` Kevin Traynor
2020-03-09 11:43 ` [dpdk-dev] [PATCH 05/28] net/ice/base: allow VLAN and ethertype filter for port Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 06/28] net/ice/base: replace u16 with enum Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 07/28] net/ice/base: use struct size helper Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 08/28] net/ice/base: use descriptive vairiable name than type Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 09/28] net/ice/base: refactor a function Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 10/28] net/ice/base: add NVM netlist macros Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 11/28] net/ice/base: minor fixes Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 12/28] net/ice/base: support GTPU uplink and downlink Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 13/28] net/ice/base: add link default override support Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 14/28] net/ice/base: add dedicate MAC type for E810 Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 15/28] net/ice/base: capitalize abbreviations Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 16/28] net/ice/base: add PHY number definition values Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 17/28] net/ice/base: add shared driver parameter command Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 18/28] net/ice/bse: add AN masks to Get PHY Caps Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 19/28] net/ice/base: xtract logic of flat NVM read to function Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 20/28] net/ice/base: add macro specifying max NVM offset Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 21/28] net/ice/base: implement new sr read functions Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 22/28] net/ice/base: couple casting issue fixes Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 23/28] net/ice/base: support PHY persistent feature Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 24/28] net/ice/base: store NVM version info in extracted format Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 25/28] net/ice/base: add ACL module Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 26/28] net/ice/base: update copyright date Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 27/28] net/ice/base: add the hook to send AdminQ command Qi Zhang
2020-03-09 11:43 ` [dpdk-dev] [PATCH 28/28] net/ice/base: don't access some hardware registers in DCF Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 00/36] update ice base code Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 01/36] net/ice/base: fix uninitialized stack variables Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 02/36] net/ice/base: add and update E822 device IDs Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 03/36] net/ice/base: fix removing MAC rule Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 04/36] net/ice/base: read PSM clock frequency from register Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 05/36] net/ice/base: allow VLAN and ethertype filter for port Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 06/36] net/ice/base: replace u16 with enum Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 07/36] net/ice/base: use struct size helper Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 08/36] net/ice/base: use descriptive vairiable name than type Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 09/36] net/ice/base: refactor a function Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 10/36] net/ice/base: add NVM netlist macros Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 11/36] net/ice/base: minor fixes Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 12/36] net/ice/base: support GTPU uplink and downlink Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 13/36] net/ice/base: add link default override support Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 14/36] net/ice/base: add dedicate MAC type for E810 Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 15/36] net/ice/base: capitalize abbreviations Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 16/36] net/ice/base: add PHY number definition values Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 17/36] net/ice/base: add shared driver parameter command Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 18/36] net/ice/base: add AN masks to Get PHY Caps Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 19/36] net/ice/base: xtract logic of flat NVM read to function Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 20/36] net/ice/base: add macro specifying max NVM offset Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 21/36] net/ice/base: implement new sr read functions Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 22/36] net/ice/base: couple casting issue fixes Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 23/36] net/ice/base: support PHY persistent feature Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 24/36] net/ice/base: store NVM version info in extracted format Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 25/36] net/ice/base: add ACL module Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 26/36] net/ice/base: update copyright date Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 27/36] net/ice/base: add the hook to send AdminQ command Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 28/36] net/ice/base: don't access some hardware registers in DCF Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 29/36] net/ice/base: move functions from common to NVM module Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 30/36] net/ice/base: discover and store size of available flash Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 31/36] net/ice/base: check DDP package compatibility Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 32/36] net/ice/base: fix MAC write command Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 33/36] net/ice/base: misc cleanups for Flow Director Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 34/36] net/ice/base: add check to ipv4 next protocol Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 35/36] net/ice/base: add reference count to tunnels Qi Zhang
2020-03-23 7:17 ` [dpdk-dev] [PATCH v2 36/36] net/ice/base: add pppoe ipv6 dummy packet Qi Zhang
2020-03-24 3:11 ` [dpdk-dev] [PATCH v2 00/36] update ice base code Yang, Qiming
2020-03-24 6:39 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611547E54BD@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=benjamin.h.shelton@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=paul.m.stillwell.jr@intel.com \
--cc=qiming.yang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).