DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Jiang, JunyuX" <junyux.jiang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>, "Su, Simei" <simei.su@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/ice: initialize and update RSS based on user request
Date: Tue, 23 Jun 2020 09:40:07 +0000
Message-ID: <039ED4275CED7440929022BC67E7061154843A6B@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20200623083312.16883-1-junyux.jiang@intel.com>



> -----Original Message-----
> From: Jiang, JunyuX <junyux.jiang@intel.com>
> Sent: Tuesday, June 23, 2020 4:33 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Su, Simei <simei.su@intel.com>; Jiang, JunyuX
> <junyux.jiang@intel.com>
> Subject: [PATCH v3] net/ice: initialize and update RSS based on user request
> 
> Initialize and update RSS configure based on user request
> (rte_eth_rss_conf) from dev_configure and .rss_hash_update ops.
> All previous default configure has been removed.
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> 
> ---
> v2->v3:
> change the commit log
> Separate ipv4 and ipv6
> Remove the call of ice_rem_vsi_rss_cfg()
> 
> v1->v2:
> remove gtpu and pppoe/pppod configuration from rss init
> ---
>  drivers/net/ice/ice_ethdev.c | 169 +++++++++++++++++++++--------------
>  drivers/net/ice/ice_ethdev.h |   2 +
>  2 files changed, 104 insertions(+), 67 deletions(-)
> 
...
> +	if (rss_conf->rss_hf == 0)
> +		return -EINVAL;

This looks not correct, user may only want to update hash key but without any RSS configure, just return success here.

> +
> +	/* RSS hash configuration */
> +	ice_rss_hash_set(pf, rss_conf->rss_hf);
> +
>  	return 0;
>  }
> 

  reply	other threads:[~2020-06-23  9:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10  6:33 [dpdk-dev] [PATCH] net/ice: support based RSS configure Junyu Jiang
2020-06-22  5:33 ` [dpdk-dev] [PATCH v2] " Junyu Jiang
2020-06-22 14:36   ` Zhang, Qi Z
2020-06-23  2:47     ` Jiang, JunyuX
2020-07-03  8:16   ` Zhao1, Wei
2020-07-03  8:46     ` Zhao1, Wei
2020-06-23  8:33 ` [dpdk-dev] [PATCH v3] net/ice: initialize and update RSS based on user request Junyu Jiang
2020-06-23  9:40   ` Zhang, Qi Z [this message]
2020-06-24  2:09 ` [dpdk-dev] [PATCH v4] " Junyu Jiang
2020-06-24  7:30   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=039ED4275CED7440929022BC67E7061154843A6B@SHSMSX103.ccr.corp.intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=junyux.jiang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=simei.su@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git