From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B23EA0350; Tue, 23 Jun 2020 11:40:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E27A71D5F9; Tue, 23 Jun 2020 11:40:13 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id AFEB31D5E9 for ; Tue, 23 Jun 2020 11:40:12 +0200 (CEST) IronPort-SDR: UcHke1fTaxb9+7wOxnBYUCo/3lCReWVYhlvz6mR6kb9F2Nk9KoYvGnxp21Z3zZuL6AYZz6BKTS j4pk49vZpDDw== X-IronPort-AV: E=McAfee;i="6000,8403,9660"; a="131429323" X-IronPort-AV: E=Sophos;i="5.75,270,1589266800"; d="scan'208";a="131429323" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2020 02:40:11 -0700 IronPort-SDR: yXo6MvLDuhdR85rD5ElM9kq+6g42Yi7rsoBlU9yAEBhg9pP37ygLNJy9tvSYcNOkJXVG/y5jkX WE7FcC8mn0rg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,270,1589266800"; d="scan'208";a="422946441" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 23 Jun 2020 02:40:11 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jun 2020 02:40:11 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jun 2020 02:40:10 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.89]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.25]) with mapi id 14.03.0439.000; Tue, 23 Jun 2020 17:40:08 +0800 From: "Zhang, Qi Z" To: "Jiang, JunyuX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Su, Simei" Thread-Topic: [PATCH v3] net/ice: initialize and update RSS based on user request Thread-Index: AQHWSTxLieokzEP0TUiB4l0JjYCLQqjl8ZJQ Date: Tue, 23 Jun 2020 09:40:07 +0000 Message-ID: <039ED4275CED7440929022BC67E7061154843A6B@SHSMSX103.ccr.corp.intel.com> References: <20200610063355.35172-1-junyux.jiang@intel.com> <20200623083312.16883-1-junyux.jiang@intel.com> In-Reply-To: <20200623083312.16883-1-junyux.jiang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/ice: initialize and update RSS based on user request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jiang, JunyuX > Sent: Tuesday, June 23, 2020 4:33 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Su, Simei ; Jiang, JunyuX > > Subject: [PATCH v3] net/ice: initialize and update RSS based on user requ= est >=20 > Initialize and update RSS configure based on user request > (rte_eth_rss_conf) from dev_configure and .rss_hash_update ops. > All previous default configure has been removed. >=20 > Signed-off-by: Junyu Jiang >=20 > --- > v2->v3: > change the commit log > Separate ipv4 and ipv6 > Remove the call of ice_rem_vsi_rss_cfg() >=20 > v1->v2: > remove gtpu and pppoe/pppod configuration from rss init > --- > drivers/net/ice/ice_ethdev.c | 169 +++++++++++++++++++++-------------- > drivers/net/ice/ice_ethdev.h | 2 + > 2 files changed, 104 insertions(+), 67 deletions(-) >=20 ... > + if (rss_conf->rss_hf =3D=3D 0) > + return -EINVAL; This looks not correct, user may only want to update hash key but without a= ny RSS configure, just return success here. > + > + /* RSS hash configuration */ > + ice_rss_hash_set(pf, rss_conf->rss_hf); > + > return 0; > } >=20