From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F503A0527; Wed, 15 Jul 2020 16:02:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 850CC1BEAC; Wed, 15 Jul 2020 16:02:13 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 367BA1BE8C for ; Wed, 15 Jul 2020 16:02:11 +0200 (CEST) IronPort-SDR: m+Ish+oDAQda88U8f0D4SeJ2h0RdTfakd1I7uNQSWPTtxVem1AL5syz7NNXJJnJRlN1HV97eYa HbFSG2DZJs4A== X-IronPort-AV: E=McAfee;i="6000,8403,9682"; a="149143379" X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="149143379" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 07:02:11 -0700 IronPort-SDR: PKefA3VC/lPSN8xkZULLrwRUZ32dJoz+LjXx3J3oAzV4Wj3jGp5XK7NCueOLaKKb4p6vbK5RaM PjUMGkDiK1MA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="430130924" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 15 Jul 2020 07:02:10 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jul 2020 07:02:10 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jul 2020 07:02:10 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.22]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.22]) with mapi id 14.03.0439.000; Wed, 15 Jul 2020 22:02:07 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "Lu, Nannan" Thread-Topic: [PATCH] net/ice: fix tunnel type get error Thread-Index: AQHWWlBVR7BqIVQmOk2opWwRuL8cD6kIrDKg Date: Wed, 15 Jul 2020 14:02:06 +0000 Message-ID: <039ED4275CED7440929022BC67E706115485D6D1@SHSMSX103.ccr.corp.intel.com> References: <20200715020733.45086-1-wei.zhao1@intel.com> In-Reply-To: <20200715020733.45086-1-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: fix tunnel type get error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, July 15, 2020 10:08 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Lu, Nannan ; > Zhao1, Wei > Subject: [PATCH] net/ice: fix tunnel type get error >=20 > When get tunnel type for ICE_NON_TUN, there need some upodate for gtp > related pctype. please reword the commit log, what do you mean "get tunnel type for ICE_NON= _TUN"? also we don't have pctype in ice, please use profile. >=20 > Fixes: 418d2563d10b ("net/ice/base: get tunnel type for recipe") >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/ice/base/ice_switch.c | 4 ++-- drivers/net/ice/base/ice_swi= tch.h > | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ice/base/ice_switch.c > b/drivers/net/ice/base/ice_switch.c > index 296aa5484..ebf405f7a 100644 > --- a/drivers/net/ice/base/ice_switch.c > +++ b/drivers/net/ice/base/ice_switch.c > @@ -1069,7 +1069,7 @@ static enum ice_sw_tunnel_type > ice_get_tun_type_for_recipe(u8 rid) > non_tun_valid =3D true; > } >=20 > - if (j >=3D ICE_PROFID_IPV4_GTPC_TEID && > + if (j >=3D ICE_PROFID_IPV4_GTPU_EH_IPV4_OTHER && > j <=3D ICE_PROFID_IPV6_GTPU_IPV6_OTHER) > gtp_valid =3D true; >=20 > @@ -1136,7 +1136,7 @@ static enum ice_sw_tunnel_type > ice_get_tun_type_for_recipe(u8 rid) > tun_type =3D ICE_SW_TUN_PPPOE_IPV6_TCP; > break; > case ICE_PROFID_PPPOE_IPV6_UDP: > - tun_type =3D ICE_SW_TUN_PPPOE_IPV4_UDP; > + tun_type =3D ICE_SW_TUN_PPPOE_IPV6_UDP; > break; > case ICE_PROFID_PPPOE_IPV6_OTHER: > tun_type =3D ICE_SW_TUN_PPPOE_IPV6; > diff --git a/drivers/net/ice/base/ice_switch.h > b/drivers/net/ice/base/ice_switch.h > index cc3d2702e..77c70d3b2 100644 > --- a/drivers/net/ice/base/ice_switch.h > +++ b/drivers/net/ice/base/ice_switch.h > @@ -28,6 +28,7 @@ > #define ICE_PROFID_PPPOE_IPV6_UDP 39 > #define ICE_PROFID_PPPOE_IPV6_OTHER 40 > #define ICE_PROFID_IPV4_GTPC_TEID 41 > +#define ICE_PROFID_IPV4_GTPU_EH_IPV4_OTHER 47 > #define ICE_PROFID_IPV6_GTPU_IPV6_OTHER 70 > #define ICE_PROFID_IPV4_ESP 71 > #define ICE_PROFID_IPV6_ESP 72 > -- > 2.19.1